-
Notifications
You must be signed in to change notification settings - Fork 7.6k
3.x: Have all unit tests extend a base test class #6583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey, I see the interest having a global timeout in a base class. Please note that in Junit4, the timeout parameter on |
No problem, default 2-5 minutes should work. Travis kills the build if no standard output is happening for 10 minutes. Announce should create a log print often. Ignore should be reevaluated in place and deleted if no longer needed. |
Thanks, I'll submit a PR. |
This commit creates the `RxJavaTest` class defining a default timeout to 5 minutes. An ignored test announce itself for each running class extending it preventing Travis CI from killing the build. Have `Completable` tests extend from `RxJavaTest`. Have `Disposable` tests extend from `RxJavaTest`. Have `Exception` tests extend from `RxJavaTest` Closes: ReactiveX#6583
This commit creates the `RxJavaTest` class defining a default timeout to 5 minutes. An ignored test announce itself for each running class extending it preventing Travis CI from killing the build. Have `Completable` tests extend from `RxJavaTest`. Have `Disposable` tests extend from `RxJavaTest`. Have `Exception` tests extend from `RxJavaTest` Related: ReactiveX#6583
This commit creates the `RxJavaTest` class defining a default timeout to 5 minutes. An ignored test announce itself for each running class extending it preventing Travis CI from killing the build. Have `Completable` tests extend from `RxJavaTest`. Have `Disposable` tests extend from `RxJavaTest`. Have `Exception` tests extend from `RxJavaTest` Related: ReactiveX#6583
This commit creates the `RxJavaTest` class defining a default timeout to 5 minutes. An ignored test announce itself for each running class extending it preventing Travis CI from killing the build. Have `Completable` tests extend from `RxJavaTest`. Have `Disposable` tests extend from `RxJavaTest`. Have `Exception` tests extend from `RxJavaTest` Related: #6583
This commit updates the unit tests of the following operators: * flowable * maybe * observable * disposable * observer * parallel * processors * schedulers and RxJava plugin. Related: ReactiveX#6583
This commit updates the unit tests of the following operators: * flowable * maybe * observable * disposable * observer * parallel * processors * schedulers and RxJava plugin. Related: ReactiveX#6583
This commit updates the unit tests of the following operators: * flowable * maybe * observable * disposable * observer * parallel * processors * schedulers and RxJava plugin. Related: #6583
This commit updates the unit tests of the following operators: * single * subjects * subscribers And for internal operators: * internal.disposable * internal.fuctions * internal.observers * internal.queue * interanl.schedulers * internal.subscribers * internal.subscriptions * internal.operator.completable Related: ReactiveX#6583
This commit updates the unit tests of the following operators: * single * subjects * subscribers And for internal operators: * internal.disposable * internal.fuctions * internal.observers * internal.queue * interanl.schedulers * internal.subscribers * internal.subscriptions * internal.operator.completable Related: #6583
This commit updates the unit tests for `internal.operator.flowable` Related: ReactiveX#6583
This commit updates the unit tests for `internal.operator.flowable` Related: ReactiveX#6583
This commit updates the unit tests of the following operators: * internal.operators.maybe * internal.operator.mixed * internal.operator.single Related: ReactiveX#6583
This commit updates the unit tests of the following operators: * internal.operators.maybe * internal.operator.mixed * internal.operator.single Related: #6583
…st` - 6 This commit updates the unit tests for `internal.operator.observable` Related: ReactiveX#6583
Hey,
Also, I did not update Technology Compatibility Kit (TCK) tests. |
Don't worry about them. Thanks for your diligent work! |
By adding a common base class, we can enable a "global" timeout and a per-class log output that prevents Travis CI to stop the build and also not flood the log with all methods:
This way, we no longer have to rely on the random ignores scattered along the codebase. This baseclass-ignore may seem unnecessarily complicated, but unfortunately, I was unable to create a working setting via Gradle's test runner.
The text was updated successfully, but these errors were encountered: