Skip to content

Parameter set #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Parameter set #450

wants to merge 18 commits into from

Conversation

rickwierenga
Copy link
Member

same as #271 (due to https://discuss.pylabrobot.org/t/fixing-git-lfs-for-plr-required-rewriting-git-history/70)

ParameterSet is nice because we can pass a single parameter to a function that performs a transfer to specify it completely, without having to have two parameters one for asp and one for disp. this ensures eg blow out air volume and transport air volume are the same between the operation. it also provides a way for the user to specify which parameters should go to asp and disp (or both). if we only pass a dict, we would need an additional argument to determine which parameter should go to asp or disp or both

the ParameterSet class is quite empty and ugly and i might refactor aggressively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants