Skip to content

(GH-1336) Add syntax aware folding provider #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 2, 2018
Merged

(GH-1336) Add syntax aware folding provider #1355

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e50704e
(GH-1336) Add syntax aware folding provider
glennsarti Jun 13, 2018
09c8ade
(GH-1336) Add syntax folding for braces and parentheses
glennsarti Jun 13, 2018
f5ee6d2
(GH-1336) Add syntax folding for here strings
glennsarti Jun 13, 2018
1e15180
(GH-1336) Add syntax folding for comments
glennsarti Jun 13, 2018
6a99426
(GH-1336) Add Code Folding settings and enable by default
glennsarti Jun 28, 2018
0434ff8
(GH-1336) Add integration tests for the Folding Provider
glennsarti Jun 18, 2018
5156173
(maint) Modify tslint configuration for test files
glennsarti Jun 20, 2018
d9a9e6d
add copyright headers
TylerLeonhardt Jun 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"publisher": "ms-vscode",
"description": "Develop PowerShell scripts in Visual Studio Code!",
"engines": {
"vscode": "^1.22.0"
"vscode": "^1.23.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the version increment required for this PR? I don't think we have a particular policy, but dependency version changes are important enough that it would be worth considering having that as its own PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The Folding API only exists in 1.23.0+

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous changes didn't separate PRs for it.
790e6e2

5ad413c

#748

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'm convinced 😄

@tylerl0706 Maybe we should consider this a policy for the future, especially with all the feature work going into VSCode — I know .NET Core's latest update was surprisingly tricky for PowerShell.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could. We haven't gotten burned by it yet AFAIK but it doesn't hurt. Next time :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time was last time :-P

},
"license": "SEE LICENSE IN LICENSE.txt",
"homepage": "https://github.com/PowerShell/vscode-powershell/blob/master/README.md",
Expand Down Expand Up @@ -52,7 +52,7 @@
"vscode.powershell"
],
"scripts": {
"compile": "tsc -v && tsc -p ./ && tslint -p ./ -e test/*",
"compile": "tsc -v && tsc -p ./ && tslint -p ./",
"compile-watch": "tsc -watch -p ./",
"postinstall": "node ./node_modules/vscode/bin/install",
"test": "node ./node_modules/vscode/bin/test"
Expand Down Expand Up @@ -467,6 +467,11 @@
"default": "",
"description": "Specifies the path to a PowerShell Script Analyzer settings file. To override the default settings for all projects, enter an absolute path, or enter a path relative to your workspace."
},
"powershell.codeFolding.enable": {
"type": "boolean",
"default": true,
"description": "Enables syntax based code folding. When disabled, the default indentation based code folding is used."
},
"powershell.codeFormatting.preset": {
"type": "string",
"enum": [
Expand Down
Loading