Close stray processes on exit #663
Conversation
| @@ -70,7 +70,7 @@ public class EditorServicesHost | |||
| private IServerListener languageServiceListener; | |||
| private IServerListener debugServiceListener; | |||
|
|
|||
| private TaskCompletionSource<bool> serverCompletedTask; | |||
| private TaskCompletionSource<bool> serverCompletedTask = new TaskCompletionSource<bool>(); | |||
There was a problem hiding this comment.
I see this is also assigned in the constructor. Is there a need to initialise it here as well? Can we initialise it in the constructor instead of here?
There was a problem hiding this comment.
It's assigned in the constructor of LanguageServer not EditorServicesHost.
I could move the assignment to the constructor of EditorServices as well though - like featureFlags.
| @@ -146,6 +155,7 @@ protected Task Stop() | |||
| Logger.Write(LogLevel.Normal, "Language service is shutting down..."); | |||
|
|
|||
| // TODO: Raise an event so that the host knows to shut down | |||
There was a problem hiding this comment.
Does this mean the TODO is done?
|
So the way the language server stays running is because of this line: $editorServicesHost.WaitForCompletion()That function really just waits for So what I've done is plumbed that CompletionTask down to where we receive the When the task completes, WaitForCompletion() finishes executing and thus, PowerShell itself finishes executing Start-EditorServices.ps1 and exits. |
| @@ -156,7 +166,6 @@ protected Task Stop() | |||
| RequestContext<object> requestContext) | |||
| { | |||
| // Allow the implementor to shut down gracefully | |||
| await this.Stop(); | |||
There was a problem hiding this comment.
This looks like we are simply ignoring the ShutdownRequest message? Does this mean we are really only processing the ExitNotification message in order to stop the lang server?
There was a problem hiding this comment.
That's correct. The shutdown message is not supposed to actually do things that would stop the process.
It's the message that gets sent to inform the language server that a shutdown is occurring and that you should expect an exit message soon.
Fixes #655
This shuts down PSES when it receives the
exitmessage following the language server protocol.This also makes the
shutdownmessage NOT kill the server which also follows the language server protocol.I've tested this using the NeoVim Language Client