Fix crash when performing symbol operations in untitled file #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a host crash which occurs when the user tries to perform a symbol operation (like Go to Definition or Find References) in an untitled script file. The fix is to not try and convert an untitled file's path to a Uri. Resolves PowerShell/vscode-powershell#645
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
Fix PowerShell#418: Debugger should retry if extension isn't loaded yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a host crash which occurs when the user tries to
perform a symbol operation (like Go to Definition or Find References) in
an untitled script file. The fix is to not try and convert an untitled
file's path to a Uri.
Resolves PowerShell/vscode-powershell#645