Fixes #195 - set breakpoint in non-existing file doesn't crash #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the crash at the protocol layer for VSCode.
|
Looks good, let's go with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the crash at the protocol layer for VSCode. This does not cause the debug host to spit anything out to the debug console. I was finding a good way to get a ScriptFile down to the SetLineBreakpoint() method for a source path that does not exist. I figured at the least, we could eliminate the debug host crash for now.
I also believe the VSCode folks should fix this by displaying our message in the breakpoints list UI. See microsoft/vscode#4935
This change is