Ruleset: remove support for the deprecated ruleset.xml array property string-based syntax #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… string-based syntax The old syntax was deprecated in PHPCS 3.3.0, which also introduced support for using `<element...>` nodes as a replacement. Includes splitting off the tests for the old-style, comma-delimited string manner of setting an array property to a separate test class with its own fixtures. Refs: * squizlabs/PHP_CodeSniffer 1665 Fixes squizlabs/PHP_CodeSniffer 1983 Related to 6 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
greg0ire
approved these changes
Apr 14, 2025
jrfnl
deleted the
phpcs-4.0/feature/sq-1983-ruleset-remove-support-old-array-syntax
branch
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old syntax was deprecated in PHPCS 3.3.0, which also introduced support for using
<element...>nodes as a replacement.Includes splitting off the tests for the old-style, comma-delimited string manner of setting an array property to a separate test class with its own fixtures.
Refs:
Suggested changelog entry
ruleset.xmlarray property string-based syntax has been removed.print=>echo,create_function=>nullelementtag withkeyandvalueattributes<element key="print" value="echo">Related issues/external references
Fixes squizlabs/PHP_CodeSniffer#1983
Related to #6