Skip to content

Fix links for 'Ayra TDC Triple Burst' #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2022
Merged

Conversation

luc122c
Copy link
Contributor

@luc122c luc122c commented Oct 15, 2022

Fix a link found by #999. Also added product page and video.

@luc122c luc122c added bug Something doesn't work as intended. component-fixture Affects one or more existing fixture definitions. labels Oct 15, 2022
@luc122c luc122c self-assigned this Oct 15, 2022
@luc122c luc122c requested a review from FloEdelmann October 15, 2022 20:38
@luc122c
Copy link
Contributor Author

luc122c commented Oct 15, 2022

It looks like my formatter has also made some changes. I'll try not to commit these in the future.

@github-actions
Copy link

Plugin export diff

(Output of test script tests/github/export-diff.js.)

You can view your uncommitted changes in plugin exports manually by executing:
$ node cli/diff-plugin-outputs.js -p <plugin-key> [-c <compare-plugin-key>] <fixtures>

🆚 ayra/tdc-triple-burst: aglight
Changed outputted file aglight_fixture_library.json
--- removed
+++ added
@@ -11,13 +11,17 @@
         "createDate": "2017-12-14",
         "lastModifyDate": "2018-08-09"
       },
       "links": {
+        "productPage": [
+          "https://www.bax-shop.co.uk/led-light-effect/ayra-tdc-triple-burst-led-lichteffect"
+        ],
         "manual": [
-          "https://www.bax-shop.nl/downloads/products/9000-0007-6647/ayra_tdc_triple_burst_manual.pdf"
+          "https://manualzz.com/doc/6501525/tdc-triple-burst-dmx-led-light-effect-user-manual---bax"
         ],
         "video": [
-          "https://www.youtube.com/watch?v=WKCW9-JtCfs"
+          "https://www.youtube.com/watch?v=WKCW9-JtCfs",
+          "https://www.youtube.com/watch?v=Xt2d_Y9eGzs"
         ]
       },
       "physical": {
         "dimensions": [375, 260, 100],
💤 ayra/tdc-triple-burst: color-chief Outputted files not changed.
💤 ayra/tdc-triple-burst: colorsource Outputted files not changed.
💤 ayra/tdc-triple-burst: d-light Outputted files not changed.
💤 ayra/tdc-triple-burst: dmxcontrol3 Outputted files not changed.
🆚 ayra/tdc-triple-burst: dragonframe
Changed outputted file ayra/tdc-triple-burst.json
--- removed
+++ added
@@ -8,13 +8,17 @@
     "createDate": "2017-12-14",
     "lastModifyDate": "2018-08-09"
   },
   "links": {
+    "productPage": [
+      "https://www.bax-shop.co.uk/led-light-effect/ayra-tdc-triple-burst-led-lichteffect"
+    ],
     "manual": [
-      "https://www.bax-shop.nl/downloads/products/9000-0007-6647/ayra_tdc_triple_burst_manual.pdf"
+      "https://manualzz.com/doc/6501525/tdc-triple-burst-dmx-led-light-effect-user-manual---bax"
     ],
     "video": [
-      "https://www.youtube.com/watch?v=WKCW9-JtCfs"
+      "https://www.youtube.com/watch?v=WKCW9-JtCfs",
+      "https://www.youtube.com/watch?v=Xt2d_Y9eGzs"
     ]
   },
   "physical": {
     "dimensions": [375, 260, 100],
💤 ayra/tdc-triple-burst: ecue Outputted files not changed.
🆚 ayra/tdc-triple-burst: millumin
Changed outputted file ayra/tdc-triple-burst.json
--- removed
+++ added
@@ -7,9 +7,9 @@
     "authors": ["Flo Edelmann"],
     "createDate": "2017-12-14",
     "lastModifyDate": "2018-08-09"
   },
-  "manualURL": "https://www.bax-shop.nl/downloads/products/9000-0007-6647/ayra_tdc_triple_burst_manual.pdf",
+  "manualURL": "https://manualzz.com/doc/6501525/tdc-triple-burst-dmx-led-light-effect-user-manual---bax",
   "physical": {
     "dimensions": [375, 260, 100],
     "weight": 3,
     "power": 60,
💤 ayra/tdc-triple-burst: op-z Outputted files not changed.
💤 ayra/tdc-triple-burst: qlcplus_4.12.2 Outputted files not changed.

@github-actions
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ ayra / tdc-triple-burst: d-light / attributes-correctness
  • ✔️ ayra/tdc-triple-burst-1ch.xml
  • ✔️ ayra/tdc-triple-burst-3ch.xml
  • ✔️ ayra/tdc-triple-burst-9ch.xml
  • ✔️ ayra/tdc-triple-burst-15ch.xml
  • ✔️ ayra/tdc-triple-burst-19ch.xml
✔️ ayra / tdc-triple-burst: dmxcontrol3 / channel-numbers
  • ✔️ ayra-tdc-triple-burst-1ch.xml
  • ✔️ ayra-tdc-triple-burst-3ch.xml
  • ✔️ ayra-tdc-triple-burst-9ch.xml
  • ✔️ ayra-tdc-triple-burst-15ch.xml
  • ✔️ ayra-tdc-triple-burst-19ch.xml
✔️ ayra / tdc-triple-burst: dragonframe / json-schema-conformity
  • ✔️ ayra/tdc-triple-burst.json
  • ✔️ manufacturers.json
✔️ ayra / tdc-triple-burst: millumin / json-schema-conformity
  • ✔️ ayra/tdc-triple-burst.json
✔️ ayra / tdc-triple-burst: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Ayra-TDC-Triple-Burst.qxf
✔️ ayra / tdc-triple-burst: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Ayra-TDC-Triple-Burst.qxf

@luc122c luc122c added the hacktoberfest Good issue for users participating in the Hacktoberfest. label Oct 15, 2022
@FloEdelmann FloEdelmann merged commit 4b1b8cf into master Oct 16, 2022
@FloEdelmann FloEdelmann deleted the fix-ayra-tdc-triple-burst branch October 16, 2022 20:12
@FloEdelmann
Copy link
Member

Thanks!

@luc122c luc122c restored the fix-ayra-tdc-triple-burst branch February 28, 2023 22:18
@luc122c luc122c deleted the fix-ayra-tdc-triple-burst branch February 28, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work as intended. component-fixture Affects one or more existing fixture definitions. hacktoberfest Good issue for users participating in the Hacktoberfest.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants