Skip to content

Fix some broken links #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 2, 2020
Merged

Fix some broken links #1272

merged 5 commits into from
May 2, 2020

Conversation

FloEdelmann
Copy link
Member

Reported by #999.

@FloEdelmann FloEdelmann added the component-fixture Affects one or more existing fixture definitions. label Apr 24, 2020
@FloEdelmann FloEdelmann requested a review from fxedel April 24, 2020 09:12
@FloEdelmann
Copy link
Member Author

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ ape-labs / lightcan: d-light / attributes-correctness
  • ✔️ ape-labs/lightcan-3ch.xml
  • ✔️ ape-labs/lightcan-4ch.xml
  • ✔️ ape-labs/lightcan-8ch.xml
✔️ ape-labs / lightcan: millumin / json-schema-conformity
  • ✔️ ape-labs/lightcan.json
✔️ ape-labs / lightcan: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Ape-Labs-LightCan.qxf
✔️ ape-labs / lightcan: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Ape-Labs-LightCan.qxf
✔️ ibiza-light / lp64-led-promo: d-light / attributes-correctness
  • ✔️ ibiza-light/lp64-led-promo-7ch.xml
✔️ ibiza-light / lp64-led-promo: millumin / json-schema-conformity
  • ✔️ ibiza-light/lp64-led-promo.json
✔️ ibiza-light / lp64-led-promo: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Ibiza-light-LP64-LED-PROMO.qxf
✔️ ibiza-light / lp64-led-promo: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Ibiza-light-LP64-LED-PROMO.qxf
✔️ laserworld / cs-1000rgb: d-light / attributes-correctness
  • ✔️ laserworld/cs-1000rgb-11ch.xml
✔️ laserworld / cs-1000rgb: millumin / json-schema-conformity
  • ✔️ laserworld/cs-1000rgb.json
❌ laserworld / cs-1000rgb: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Laserworld-CS-1000RGB.qxfNamespace(convert=None, map=False, validate=['.']) manufacturer/fixture.qxf: Invalid PAN degrees manufacturer/fixture.qxf: Invalid TILT degrees 1 definitions processed. 2 errors detected
✔️ laserworld / cs-1000rgb: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Laserworld-CS-1000RGB.qxf
✔️ mega-led-lighting / zoom-360: d-light / attributes-correctness
  • ✔️ mega-led-lighting/zoom-360-16ch.xml
  • ✔️ mega-led-lighting/zoom-360-12ch.xml
✔️ mega-led-lighting / zoom-360: millumin / json-schema-conformity
  • ✔️ mega-led-lighting/zoom-360.json
✔️ mega-led-lighting / zoom-360: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Mega-LED-Lighting-ZOOM-360.qxf
✔️ mega-led-lighting / zoom-360: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Mega-LED-Lighting-ZOOM-360.qxf
✔️ robe / spot-160-xt: d-light / attributes-correctness
  • ✔️ robe/spot-160-xt-1st.xml
  • ✔️ robe/spot-160-xt-2nd.xml
  • ✔️ robe/spot-160-xt-3rd.xml
  • ✔️ robe/spot-160-xt-4th.xml
✔️ robe / spot-160-xt: millumin / json-schema-conformity
  • ✔️ robe/spot-160-xt.json
✔️ robe / spot-160-xt: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Robe-Spot-160-XT.qxf
✔️ robe / spot-160-xt: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Robe-Spot-160-XT.qxf

@FloEdelmann FloEdelmann temporarily deployed to ofl-fix-links-adkbttqwpm20nju5 April 26, 2020 16:53 Inactive
@FloEdelmann
Copy link
Member Author

Plugin export diff

(Output of test script tests/github/export-diff.js.)

You can view your uncommitted changes in plugin exports manually by executing:
$ node cli/diff-plugin-outputs.js -p <plugin-key> [-c <compare-plugin-key>] <fixtures>

💤 ape-labs/lightcan: colorsource Outputted files not changed.
💤 ape-labs/lightcan: d-light Outputted files not changed.
💤 ape-labs/lightcan: ecue Outputted files not changed.
🆚 ape-labs/lightcan: millumin
Changed outputted file ape-labs/lightcan.json 
--- removed
+++ added
@@ -7,9 +7,9 @@
     "createDate": "2019-05-30",
     "lastModifyDate": "2019-05-30"
   },
   "comment": "Only controllable via Wireless DMX (W-APE).",
-  "manualURL": "http://download.apelabs.com/manuals/Ape_Labs_-_LightCan_-_Manual_-_web.pdf",
+  "manualURL": "https://download.apelabs.com/manuals/Ape_Labs_-_LightCan_-_Manual_-_web.pdf",
   "physical": {
     "dimensions": [55, 136, 55],
     "weight": 0.39,
     "bulb": {
💤 ape-labs/lightcan: op-z Outputted files not changed.
💤 ape-labs/lightcan: qlcplus_4.12.2 Outputted files not changed.
💤 ibiza-light/lp64-led-promo: colorsource Outputted files not changed.
💤 ibiza-light/lp64-led-promo: d-light Outputted files not changed.
💤 ibiza-light/lp64-led-promo: ecue Outputted files not changed.
💤 ibiza-light/lp64-led-promo: millumin Outputted files not changed.
💤 ibiza-light/lp64-led-promo: op-z Outputted files not changed.
💤 ibiza-light/lp64-led-promo: qlcplus_4.12.2 Outputted files not changed.
💤 laserworld/cs-1000rgb: colorsource Outputted files not changed.
💤 laserworld/cs-1000rgb: d-light Outputted files not changed.
💤 laserworld/cs-1000rgb: ecue Outputted files not changed.
💤 laserworld/cs-1000rgb: millumin Outputted files not changed.
💤 laserworld/cs-1000rgb: op-z Outputted files not changed.
💤 laserworld/cs-1000rgb: qlcplus_4.12.2 Outputted files not changed.
💤 mega-led-lighting/zoom-360: colorsource Outputted files not changed.
💤 mega-led-lighting/zoom-360: d-light Outputted files not changed.
🆚 mega-led-lighting/zoom-360: ecue
Changed outputted file UserLibrary.xml 
--- removed
+++ added
@@ -1,10 +1,10 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <Document Owner="user" TypeVersion="2" SaveTimeStamp="2020-05-02#14:33:22">
     <Library>
         <Fixtures>
-            <Manufacturer _CreationDate="2020-05-02#14:33:22" _ModifiedDate="2020-05-02#14:33:22" Name="Mega LED Lighting" Comment="" Web="http://mjledlighting.com">
-                <Fixture _CreationDate="2019-02-06#00:00:00" _ModifiedDate="2019-02-06#00:00:00" Name="ZOOM 360 (16ch mode)" NameShort="MJ-1006B-16ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.org/mega-led-lighting/zoom-360" AllocateDmxChannels="16" Weight="10" Power="420" DimWidth="350" DimHeight="460" DimDepth="220">
+            <Manufacturer _CreationDate="2020-05-02#14:33:22" _ModifiedDate="2020-05-02#14:33:22" Name="Mega LED Lighting" Comment="" Web="https://mjledlighting.com">
+                <Fixture _CreationDate="2019-02-06#00:00:00" _ModifiedDate="2019-02-06#00:00:00" Name="ZOOM 360 (16ch mode)" NameShort="MJ-1006B-16ch" Comment="4in1 variant (generated by the Open Fixture Library – https://open-fixture-library.org/mega-led-lighting/zoom-360)" AllocateDmxChannels="16" Weight="10" Power="420" DimWidth="350" DimHeight="460" DimDepth="220">
                     <ChannelIntensity Name="Dimmer" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="1" DmxByte1="0" Constant="0" Crossfade="1" Invert="0" Precedence="LTP" ClassicPos="1">
                         <Range Name="Intensity off…bright" Start="0" End="255" AutoMenu="1" Centre="0"/>
                     </ChannelIntensity>
                     <ChannelColor Name="Red" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="2" DmxByte1="0" Constant="0" Crossfade="1" Invert="0" Precedence="LTP" ClassicPos="2">
@@ -101,9 +101,9 @@
                         <Range Name="ID 24" Start="240" End="249" AutoMenu="1" Centre="0"/>
                         <Range Name="ID 25" Start="250" End="255" AutoMenu="1" Centre="0"/>
                     </ChannelIntensity>
                 </Fixture>
-                <Fixture _CreationDate="2019-02-06#00:00:00" _ModifiedDate="2019-02-06#00:00:00" Name="ZOOM 360 (12ch mode)" NameShort="MJ-1006B-12ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.org/mega-led-lighting/zoom-360" AllocateDmxChannels="12" Weight="10" Power="420" DimWidth="350" DimHeight="460" DimDepth="220">
+                <Fixture _CreationDate="2019-02-06#00:00:00" _ModifiedDate="2019-02-06#00:00:00" Name="ZOOM 360 (12ch mode)" NameShort="MJ-1006B-12ch" Comment="4in1 variant (generated by the Open Fixture Library – https://open-fixture-library.org/mega-led-lighting/zoom-360)" AllocateDmxChannels="12" Weight="10" Power="420" DimWidth="350" DimHeight="460" DimDepth="220">
                     <ChannelIntensity Name="Dimmer" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="1" DmxByte1="0" Constant="0" Crossfade="1" Invert="0" Precedence="LTP" ClassicPos="1">
                         <Range Name="Intensity off…bright" Start="0" End="255" AutoMenu="1" Centre="0"/>
                     </ChannelIntensity>
                     <ChannelColor Name="Red" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="2" DmxByte1="0" Constant="0" Crossfade="1" Invert="0" Precedence="LTP" ClassicPos="2">
@@ -136,8 +136,8 @@
                 </Fixture>
             </Manufacturer>
         </Fixtures>
         <Tiles>
-            <Manufacturer _CreationDate="2020-05-02#14:33:22" _ModifiedDate="2020-05-02#14:33:22" Name="Mega LED Lighting" Comment="" Web="http://mjledlighting.com"/>
+            <Manufacturer _CreationDate="2020-05-02#14:33:22" _ModifiedDate="2020-05-02#14:33:22" Name="Mega LED Lighting" Comment="" Web="https://mjledlighting.com"/>
         </Tiles>
     </Library>
 </Document>
\ No newline at end of file
🆚 mega-led-lighting/zoom-360: millumin
Changed outputted file mega-led-lighting/zoom-360.json 
--- removed
+++ added
@@ -7,9 +7,10 @@
     "authors": ["Felix Edelmann"],
     "createDate": "2019-02-06",
     "lastModifyDate": "2019-02-06"
   },
-  "manualURL": "http://mjledlighting.com/Upload/%E8%8B%B1%E6%96%87%E7%89%88%E8%B5%84%E6%96%99/%E8%AF%B4%E6%98%8E%E4%B9%A6/MJ1006B-16591444880.pdf",
+  "comment": "4in1 variant",
+  "manualURL": "https://www.jackodance.it/wp-content/uploads/2019/01/MJ-1006B-zoom-led-moving-head-light.pdf",
   "physical": {
     "dimensions": [350, 460, 220],
     "weight": 10,
     "power": 420,
💤 mega-led-lighting/zoom-360: op-z Outputted files not changed.
💤 mega-led-lighting/zoom-360: qlcplus_4.12.2 Outputted files not changed.
💤 robe/spot-160-xt: colorsource Outputted files not changed.
💤 robe/spot-160-xt: d-light Outputted files not changed.
💤 robe/spot-160-xt: ecue Outputted files not changed.
💤 robe/spot-160-xt: millumin Outputted files not changed.
💤 robe/spot-160-xt: op-z Outputted files not changed.
💤 robe/spot-160-xt: qlcplus_4.12.2 Outputted files not changed.

@FloEdelmann FloEdelmann merged commit dd32d99 into master May 2, 2020
@FloEdelmann FloEdelmann deleted the fix-links branch May 2, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxedel fxedel Awaiting requested review from fxedel

Assignees

@fxedel fxedel

Labels
component-fixture Affects one or more existing fixture definitions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FloEdelmann @fxedel