Skip to content

[TRTLLM-5050][feat] Enable per-request stats with PyT backend #4156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2025

Conversation

pcastonguay
Copy link
Collaborator

@pcastonguay pcastonguay commented May 8, 2025

Description

Adds support for per-request stats via 'metrics' endpoint. Per-request stats can be obtained with the bollowing pytorch_backend_config parameters:

   enable_iter_perf_stats
   enable_iter_req_stats

Test Coverage

test_llm.py

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@pcastonguay pcastonguay requested review from jgangani and Tabrizian May 8, 2025 13:22
@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4593 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4593 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3307 completed with status: 'FAILURE'

@pcastonguay pcastonguay force-pushed the llmapi_enable_req_stats branch from c95b6fa to 4049844 Compare May 9, 2025 02:58
@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4631 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4631 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3340 completed with status: 'FAILURE'

@pcastonguay pcastonguay force-pushed the llmapi_enable_req_stats branch from 4049844 to f79c3c9 Compare May 9, 2025 13:44
@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4721 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4721 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3406 completed with status: 'FAILURE'

Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>
Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>
Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>
Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>
@pcastonguay pcastonguay force-pushed the llmapi_enable_req_stats branch from f79c3c9 to 90ccbff Compare May 12, 2025 11:41
@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4874 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4874 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3532 completed with status: 'SUCCESS'

@pcastonguay pcastonguay merged commit 9643be5 into NVIDIA:main May 13, 2025
3 checks passed
req_stat.stage = req.stage
req_stats.append(req_stat)

for req in list(self.request_queue.queue):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcastonguay I got bug with function. The input of get_queued_req_stats is a tuple, not LlmRequest. self.request_queue.put((self.next_req_id, request))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants