Skip to content

Fix data paths in TL3 short tests #5845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 12, 2025
Merged

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Mar 10, 2025

  • unifies data paths in TL3 short tests with other tests
  • improves the way the remote file system is detected in the tests

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • unifies data paths in TL3 short tests with other tests
  • improves the way the remote file system is detected in the tests

Additional information:

Affected modules and functionalities:

  • tests

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • TL1_separate_executor/test_nofw
    • TL2_FW_iterators_perf/test_pytorch
    • TL2_RN50_data_perf/test
    • TL3_RN50_short/test_tensorflow
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

- unifies data paths in TL3 short tests with other tests
- improves the way the remote file system is detected in the tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25156993]: BUILD STARTED

echo "Data access time: $runtime seconds"
if [ $runtime -gt 3 ]; then
echo "Data access time is greater than 3 seconds, skipping the test"
if [ $(stat /mnt/data/ --format="%T" -f) != "ext2/ext3" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so in this case, we are happy to not test this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is just a part of all tests there so even if we skip some of it we should not miss much of our coverage.

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25161198]: BUILD STARTED

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25167017]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25167017]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25167017]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25210480]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25210480]: BUILD PASSED

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25218888]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25219233]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25218888]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25219233]: BUILD PASSED

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25263652]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25263652]: BUILD PASSED

@JanuszL JanuszL merged commit 84f249a into NVIDIA:main Mar 12, 2025
6 checks passed
@JanuszL JanuszL deleted the fix_short_tests branch March 12, 2025 13:36
stiepan pushed a commit that referenced this pull request Mar 12, 2025
- unifies data paths in TL3 short tests with other tests
- improves the way the remote file system is detected in the tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants