Limit the upper versions of DALI wheel installation dependencies #5710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
JanuszL
reviewed
Nov 13, 2024
cmake/Dependencies.common.cmake
Outdated
| @@ -303,7 +304,7 @@ if(BUILD_NVIMAGECODEC) | |||
| message(STATUS "NVIMGCODEC_DEFAULT_INSTALL_PATH=${NVIMGCODEC_DEFAULT_INSTALL_PATH}") | |||
| add_definitions(-DNVIMGCODEC_DEFAULT_INSTALL_PATH=\"${NVIMGCODEC_DEFAULT_INSTALL_PATH}\") | |||
|
|
|||
| set(DALI_INSTALL_REQUIRES_NVIMGCODEC "\'nvidia-nvimgcodec-cu${CUDA_VERSION_MAJOR} >= ${NVIMGCODEC_REQ_VERSION}',") | |||
| set(DALI_INSTALL_REQUIRES_NVIMGCODEC "\'nvidia-nvimgcodec-cu${CUDA_VERSION_MAJOR} >= ${NVIMGCODEC_REQ_MIN_VERSION}, <= ${NVIMGCODEC_REQ_MAX_VERSION}',") | |||
There was a problem hiding this comment.
Suggested change
| set(DALI_INSTALL_REQUIRES_NVIMGCODEC "\'nvidia-nvimgcodec-cu${CUDA_VERSION_MAJOR} >= ${NVIMGCODEC_REQ_MIN_VERSION}, <= ${NVIMGCODEC_REQ_MAX_VERSION}',") | |
| set(DALI_INSTALL_REQUIRES_NVIMGCODEC "\'nvidia-nvimgcodec-cu${CUDA_VERSION_MAJOR} >= ${NVIMGCODEC_REQ_MIN_VERSION}, < ${NVIMGCODEC_REQ_MAX_VERSION}',") |
There was a problem hiding this comment.
There was a problem hiding this comment.
I agree; we know which version doesn't work. I doubt the version with the new API will appear as a patch for 0.3.
There was a problem hiding this comment.
Sure. I just cherry-picked @jantonguirao PR and added other bounds on top of it.
JanuszL
reviewed
Nov 13, 2024
cmake/Dependencies.common.cmake
Outdated
| @@ -274,7 +274,8 @@ endif() | |||
| ################################################################## | |||
| set(DALI_INSTALL_REQUIRES_NVIMGCODEC "") | |||
| if(BUILD_NVIMAGECODEC) | |||
| set(NVIMGCODEC_REQ_VERSION "0.3.0") | |||
| set(NVIMGCODEC_REQ_MIN_VERSION "0.3.0") | |||
| set(NVIMGCODEC_REQ_MAX_VERSION "0.3.0.5") | |||
There was a problem hiding this comment.
Suggested change
| set(NVIMGCODEC_REQ_MAX_VERSION "0.3.0.5") | |
| set(NVIMGCODEC_REQ_MAX_VERSION "0.4") |
|
CI MESSAGE: [20352442]: BUILD STARTED |
Signed-off-by: Joaquin Anton Guirao <janton@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
stiepan
force-pushed
the
whl_instal_deps_upper_bound
branch
from
6446067 to
5f1623e
Compare
stiepan
changed the title
JanuszL
approved these changes
Nov 13, 2024
|
CI MESSAGE: [20353711]: BUILD STARTED |
mzient
approved these changes
Nov 13, 2024
stiepan
added a commit
that referenced
this pull request
Nov 13, 2024
* Limit the maximum version of nvimagecodec for current DALI * Limit the upper versions of DALI wheel installation dependencies --------- Signed-off-by: Joaquin Anton Guirao <janton@nvidia.com> Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com> Co-authored-by: Joaquin Anton Guirao <janton@nvidia.com>
|
CI MESSAGE: [20353711]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Bug fix / Other
Description:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A