Make sure that the proper video stream index is used by the GPU decoder #5682
Conversation
- fixes the use of 0 index stream inside the GPU decoder by properly obtained index Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
proper_stream_gpu_Dec
branch
from
9275e2c to
eada8b2
Compare
|
!build |
|
CI MESSAGE: [19454423]: BUILD STARTED |
|
CI MESSAGE: [19454423]: BUILD FAILED |
| // False when the file doesn't have any correct content or doesn't have valid video stream | ||
| bool is_valid_ = false; |
There was a problem hiding this comment.
Nitpick1: move one field up for better packing.
Nitpick2:
| // False when the file doesn't have any correct content or doesn't have valid video stream | |
| bool is_valid_ = false; | |
| // False when the file doesn't have any correct content or doesn't have a valid video stream | |
| bool is_valid_ = false; |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [19481473]: BUILD STARTED |
|
CI MESSAGE: [19481473]: BUILD PASSED |
| DALI_ENFORCE(filtered_packet_, "Could not allocate av packet"); | ||
| if (!filtered_packet_) { | ||
| DALI_WARN(make_string("Could not allocate av packet for \"", Filename(), "\"")); | ||
| is_valid_ = false; |
There was a problem hiding this comment.
The sample will be skipped by the reader, is that right? So we don't try to access filtered_packet_->data when it was not allocated properly?
There was a problem hiding this comment.
That is the idea. We check if the decoder if valid during the operator instantiation and we warn and skip sample. For the decoder and video input operators (I saw we missed that, just added a commit for that) we cannot skip and just error.
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [19655629]: BUILD STARTED |
|
CI MESSAGE: [19655629]: BUILD PASSED |
JanuszL
added
the
important-fix
obtained index
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
obtained index
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A