Fix issues detected by Coverity (2024.09.30) #5652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanuszL
approved these changes
Sep 30, 2024
mzient
force-pushed
the
coverity_2024_09_30
branch
from
e1b42bf to
ffb87e5
Compare
|
CI MESSAGE: [18878606]: BUILD STARTED |
mdabek-nvidia
approved these changes
Sep 30, 2024
mzient
commented
Sep 30, 2024
| @@ -347,7 +347,7 @@ class Executor2::Impl { | |||
| auto stream_idx = assignment[&node]; | |||
|
|
|||
| node.env.order = stream_idx.has_value() | |||
| ? AccessOrder(streams_[*stream_idx]) | |||
| ? AccessOrder(streams_[*stream_idx].get()) | |||
There was a problem hiding this comment.
This change is required by Coverity, whose C++ front-end cannot resolve the function overload.
|
CI MESSAGE: [18878606]: BUILD PASSED |
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
mzient
force-pushed
the
coverity_2024_09_30
branch
from
ffb87e5 to
8d586e7
Compare
|
CI MESSAGE: [18884545]: BUILD STARTED |
|
CI MESSAGE: [18884545]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Other (e.g. Documentation, Tests, Configuration)
Description:
Assorted fixes for the issues detected by Coverity static analysis as of Sep 30th 2024.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-4058, DALI-4067