remote-feature-flag-controller: Fix flaky test #5730
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for `generateDeterministicRandomNumber` sometimes fails because it relies on the behavior of `uuidv4`, which is non-deterministic, and needs to be more lenient in the range of acceptable return values.
|
I've ran this test locally a few times and didn't get a failure, so I feel like this should help things. |
github-project-automation
bot
moved this from Needs dev review
to Review finalised - Ready to be merged
in PR review queue
MajorLift
approved these changes
May 22, 2025
| const expectedPerRange = samples / ranges.length; | ||
| const allowedDeviation = expectedPerRange * 0.3; | ||
| const allowedDeviation = expectedPerRange * 0.4; |
There was a problem hiding this comment.
Is 40% a safe range for the test's requirements? It seems like this might relax the test into validating a very-roughly uniform distribution.😅
There was a problem hiding this comment.
That's a great question. I'm not sure 😅 It seems like the range of values is wider than we expect. It also seems that if generateDeterministicRandomNumber is supposed to be deterministic, we don't have to use random UUIDs or user IDs in the test, we can use known values. But I assume that there is a specific reason we wrote the test this way and fixing it further seemed out of scope.
|
LGTM. ! |
DDDDDanica
approved these changes
May 22, 2025
github-project-automation
bot
moved this from Review finalised - Ready to be merged
to Merged, Closed or Archived
in PR review queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The test for
generateDeterministicRandomNumbersometimes fails because it relies on the behavior ofuuidv4, which is non-deterministic, and needs to be more lenient in the range of acceptable return values.References
Changelog
Checklist