-
-
Notifications
You must be signed in to change notification settings - Fork 3
add type stubs #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add type stubs #56
Conversation
32a751d
to
24e87cb
Compare
try again clean up 3rd times a charm one more
[dependency-groups] | ||
dev = ["maturin", "pytest", "pytest-benchmark"] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so uv sync
gives you all you need for maturin develop --uv
gentle ping for whenever you have a moment to look @MarshalX - I know there's probably more pressing things so I'll check back later 🙂 |
That's an amazing job, thank you!! I saw it already but did not comment immediately because this PR also integrates UV. I am still thinking about it but if we want to speed up it let's just include .pyi file :) |
i don't think anything (else, after removing EDIT: doh the lockfile! duh, let me remove that |
CodSpeed Performance ReportMerging #56 will degrade performances by 23.92%Comparing Summary
Benchmarks breakdown
|
not sure if related to my changes (i suspect not) or if these just have high variance |
@zzstoatzz that's just a noise from small bechmarks. ignore it :) |
adds a
python/libipld
to house the.pyi
file and the__all__
following the
_{module_name}
pattern that I use (and got frompydantic-core
), note thatmaturin develop
knows about themodule-name
set inpyproject.toml
let me know if there are any python type translations I messed up!
before
after