Skip to content

update phoenix template #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

sbryngelson
Copy link
Member

Maybe this will be more reliable?

@sbryngelson sbryngelson requested review from a team as code owners April 25, 2025 20:59
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.63%. Comparing base (068da2c) to head (ac3c4e5).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/simulation/m_time_steppers.fpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #826   +/-   ##
=======================================
  Coverage   43.63%   43.63%           
=======================================
  Files          66       66           
  Lines       19835    19835           
  Branches     2433     2433           
=======================================
  Hits         8655     8655           
  Misses       9688     9688           
  Partials     1492     1492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbryngelson
Copy link
Member Author

this isn't working for some reason @wilfonba -- if you look, the logs of the test GPU phoenix is passing on CI but the logs say it failed.

@sbryngelson
Copy link
Member Author

I reverted your last PR on this again because it was spuriously failing tests. I'm really not sure what's going on. Shouldn't be hard to figure out but it might not really matter if we make this change.

@wilfonba
Copy link
Contributor

@sbryngelson I'll make a note to look into this sometime over the weekend. It may not be till Sunday.

@sbryngelson
Copy link
Member Author

No worries. I'm just a bit confused about what's going on, it seems like it's worth knowing what's going on because srun should work better for everyone in the long run than using mpirun since it's a slurm system.

You may want to try running the tests locally on Phoenix using your new Phoenix template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants