-
Notifications
You must be signed in to change notification settings - Fork 98
update phoenix template #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #826 +/- ##
=======================================
Coverage 43.63% 43.63%
=======================================
Files 66 66
Lines 19835 19835
Branches 2433 2433
=======================================
Hits 8655 8655
Misses 9688 9688
Partials 1492 1492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
this isn't working for some reason @wilfonba -- if you look, the logs of the test GPU phoenix is passing on CI but the logs say it failed. |
I reverted your last PR on this again because it was spuriously failing tests. I'm really not sure what's going on. Shouldn't be hard to figure out but it might not really matter if we make this change. |
@sbryngelson I'll make a note to look into this sometime over the weekend. It may not be till Sunday. |
No worries. I'm just a bit confused about what's going on, it seems like it's worth knowing what's going on because You may want to try running the tests locally on Phoenix using your new Phoenix template. |
Maybe this will be more reliable?