Skip to content

Build fails with version 3.9.x/3.10.x on OpenBSD #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lcheylus opened this issue Jun 11, 2024 · 8 comments
Open

Build fails with version 3.9.x/3.10.x on OpenBSD #2705

lcheylus opened this issue Jun 11, 2024 · 8 comments

Comments

@lcheylus
Copy link

lcheylus commented Jun 11, 2024

How are you using the lua-language-server?

NeoVim

Which OS are you using?

OpenBSD current/amd64 (future version 7.6)

What is the issue affecting?

Compilation of luamake

Expected Behaviour

Build of lua-language-server OK with luamake on OpenBSD current/amd64

Actual Behaviour

On OpenBSD current/amd64, build of lua-language-server v3.9.3 KO => unable to build luamake

In version 3.9.3, luamake version/commit = c086f35. This version uses bee.lua version/commit 038aef6. In this version, symbol EVFILT_USER for bee.epoll is unknown on OpenBSD, see actboy168/luamake#41

Reproduction steps

  1. Git clone sources for lua-language-server v3.9.3
  2. cd 3rd/luamake
  3. Build luamake via ./compile/build.sh

=> error: use of undeclared identifier EVFILT_USER

Additional Notes

Please, update version of luamake and bee.lua in third-party modules to remove EVFILT_USER in bee.epoll.

Log File

No response

@IcaroPablo
Copy link

IcaroPablo commented Jul 19, 2024

Hey @lcheylus I'm having the exact same issue, but using updated versions of luamake and bee.lua as mentioned in actboy168/luamake#41 didn't help :/

It seems that an attempt to fix this problem was made with 84c18c3, but unfortunately it didn't work out.

Since you managed to build lua-language-server on openbsd, could you please give us some guidance on how to do it as well ?

@lcheylus
Copy link
Author

Hi @IcaroPablo
you could try to build lua-language-server version 3.9.0 on OpenBSD. See my WIP port here => https://github.com/jasperla/openbsd-wip/tree/master/devel/lua-language-server

@IcaroPablo
Copy link

@lcheylus thank you very much :D I'm gonna check it out right now

@lcheylus
Copy link
Author

lcheylus commented Aug 1, 2024

Same error with lua-language-server version 3.10.0 :(

Error on OpenBSD current/amd64 when building luamake because of EVFILT_USER used in bee.lua

$ cd lua-language-server-3.10.0/3rd/luamake
$ ninja -f compile/ninja/openbsd.ninja notest
FAILED: build/openbsd/obj/source_bee/bpoll_bsd.obj
clang -MMD -MT build/openbsd/obj/source_bee/bpoll_bsd.obj -MF build/openbsd/obj/source_bee/bpoll_bsd.obj.d -std=c++17 -fno-rtti -O2 -Wall -fvisibility=hidden -Ibee.lua -isystem /usr/local/include/inotify -DNDEBUG -o build/openbsd/obj/source_bee/bpoll_bsd.obj -c bee.lua/bee/
net/bpoll_bsd.cpp
In file included from bee.lua/bee/net/bpoll_bsd.cpp:1:
bee.lua/bee/net/bpoll_osx.cpp:48:37: error: use of undeclared identifier 'EVFILT_USER'
            EV_SET(&ev[n], kev_key, EVFILT_USER, EV_ADD, 0, 0, 0);
                                    ^
bee.lua/bee/net/bpoll_osx.cpp:51:41: error: use of undeclared identifier 'EVFILT_USER'
                EV_SET(&ev[n], kev_key, EVFILT_USER, EV_DELETE, 0, 0, 0);
                                        ^
bee.lua/bee/net/bpoll_osx.cpp:70:37: error: use of undeclared identifier 'EVFILT_USER'
            EV_SET(&ev[i], kev_key, EVFILT_USER, EV_RECEIPT, 0, 0, 0);
                                    ^
3 errors generated.
[5/35] Compile C++ build/openbsd/obj/source_bee/format.obj

@actboy168 Please could you update luamake / bee.lua version to remove use of EVFILT_USER symbols? See actboy168/luamake#41

@lcheylus lcheylus changed the title Build fails with version 3.9.3 on OpenBSD Build fails with version 3.9.x on OpenBSD Aug 1, 2024
@lcheylus lcheylus changed the title Build fails with version 3.9.x on OpenBSD Build fails with version 3.9.x/3.10.x on OpenBSD Aug 1, 2024
@CppCXY
Copy link
Collaborator

CppCXY commented Sep 11, 2024

I have created a Rust-based luals port, which might meet your requirements. see https://github.com/LuaLS/lua-language-server-rust

@lcheylus
Copy link
Author

@CppCXY Thanks for this info, I will try your LuaLS project based on Rust 👍

@actboy168
Copy link
Collaborator

@sumneko

sumneko added a commit that referenced this issue Sep 13, 2024
@sumneko
Copy link
Collaborator

sumneko commented Sep 13, 2024

After the updates to bee.lua and make.lua, there are significant interface incompatibilities. I currently don't have the time to address these compatibility issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants