Skip to content

3D ELVIRA MIR Speedup #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 78 commits into
base: develop
Choose a base branch
from
Draft

3D ELVIRA MIR Speedup #1548

wants to merge 78 commits into from

Conversation

BradWhitlock
Copy link
Member

@BradWhitlock BradWhitlock commented Apr 11, 2025 •
edited
Loading

This PR speeds up 3D ELVIRA MIR by substituting a new ExtractZonesAndMatsetPolyhedral class for ExtractZonesAndMatset when doing 3D ELVIRA. These classes are used when we extract clean zones. By making a polyhedral topology upfront, we use assumptions about the 3D structured input mesh to construct unique faces. This enables mesh merging to skip more costly operations to convert the clean zones to polyhedral.

  • This work is on a branch that derives from the existing 3D ELVIRA work. When that is merged, this PR will look a lot smaller since only a few files were changed.

image

@BradWhitlock
Expose polyhedron/plane and hexahedron/plane clipping.
706c51c
@BradWhitlock
Added numVertices method to the primitives since their other ways of …
a5ab0e9 
…recording that are not consistent.
@BradWhitlock
Started 3D elvira test.
280b51d
@BradWhitlock
Changes to make Elvira compile for 3D.
04c1762
@BradWhitlock
Fix Elvira so 2D tests work again.
f63e0b0
@BradWhitlock
First pass at making PH mesh
f5d2771
@BradWhitlock
Finished Shape functions for getting face ids.
e305a62
@BradWhitlock
Initial commit of some algorithms for making polyhedral topologies.
ed9e95a
@BradWhitlock
Debugging MakePolyhedralTopology
f93f4cc
@BradWhitlock
Improvements for mir_make_polyhedral_topology test
b81cdbe
@BradWhitlock
Fix GPU compilation and runtime issues. Rework getEdges functions in …
2d92845 
…shape traits.
@BradWhitlock
Adjust Conduit copying to fix a bug copying data from device to host.
1e96a79
@BradWhitlock
Hooking up code to clean mesh.
1d5d9a1
@BradWhitlock
Enhanced MergeMeshes with some polyhedral mesh support.
68eec3c
@BradWhitlock
Merged elvira branch into this branch.
bb3f0d2
@BradWhitlock
Improvements for MergeCoordsetPoints.
d8b20d7
@BradWhitlock
make style
2b5ccc8
@BradWhitlock
Added Polyhedral support to TopologyMapper. Added a CI test for it. E…
c310707 
…nhanced Polyhedra so it is easier to get faces. Added more clip routines for polyhedra.
@BradWhitlock
make style
2415c29
@BradWhitlock
Added better conduit comparison. Changed a test because Conduit was n…
3ed3c6a 
…ot providing good results for one of its datasets.
@BradWhitlock
Moved Unique class to its own file and added some debug print info. F…
6400678 
…inally, I change the serial algorithm so it better matches the base algorithm.
@BradWhitlock
Added a little bit of documentation for some new classes.
1816b0a
@BradWhitlock
make style
813d1f0
@BradWhitlock
Added elvira3d functions
1c25885
@BradWhitlock
3D Elvira support. Make 3D MeshTester example faster to generate
382cd15
@BradWhitlock
make style
05f8ebc
@BradWhitlock
Improved elvira3d test so it computes the mir volume and compares it …
adea877 
…against the original volume.
@BradWhitlock
Merged elvira into this elvira3d branch.
f1f0f32
@BradWhitlock
Use new pjoin in newer tests.
da6a25b
@BradWhitlock
Added CoordsetExtents and a test. Also made various small fixes and c…
737e46d 
…ode cleanup changes.
@BradWhitlock
Removed old comments and an extra return.
3f18987
@BradWhitlock
changed macro to use for StaticArray initialization so we do not init…
247f538 
… on Release builds.
@BradWhitlock
Fix ELVIRA3D so it can handle meshes with 64-bit IndexType.
82dad4f
@BradWhitlock
make style
0b6323a
@BradWhitlock
Fixed a problem in PrimalAdaptor where the zone went out of scope and…
53c5f0d 
… we accessed its node ids.
@BradWhitlock
Fixed a size problem in making ELVIRA 3D output. Added some asserts.
954724d
@BradWhitlock
Increasing allowed PH mesh sizes.
8f5d6d1
@BradWhitlock
Try to readjust code formatting to develop
507342f
@BradWhitlock
Merged develop into branch. Fixed a GPU issue.
16231bf
@BradWhitlock
make style
6bf59c2
@BradWhitlock
Updated release notes
b55a2af
@BradWhitlock
Changes to try and use less memory for Elvira 3D
10f1727
@BradWhitlock
make style
933e850
@BradWhitlock
Fix script
6991bbe
@BradWhitlock
Update data
d7ada4c
@BradWhitlock
Merge branch 'develop' into feature/whitlock/mir_elvira3d
2e8a164
@BradWhitlock
Corrected RELEASE-NOTES.md
c1062ac
@BradWhitlock
Merge branch 'feature/whitlock/mir_elvira3d' of github.com:LLNL/axom …
c8207d5 
…into feature/whitlock/mir_elvira3d
@BradWhitlock
Debug output fix
59c6df3
@BradWhitlock
Small fixes
fc5ef16
@BradWhitlock
Merge branch 'develop' into feature/whitlock/mir_elvira3d
e3cab08
@BradWhitlock
Merge branch 'develop' into feature/whitlock/mir_elvira3d
3fe779d
@BradWhitlock
Fix typo
8d56d65
@BradWhitlock
Merge branch 'feature/whitlock/mir_elvira3d' of github.com:LLNL/axom …
6e19716 
…into feature/whitlock/mir_elvira3d
@BradWhitlock
Updated data directory version.
f608f67
@BradWhitlock
Initial version of ExtractZonesAndMatsetPolyhedral class that can pul…
f31d0f4 
…l out selected zones from structured mesh as PH zones.
@BradWhitlock
Code cleanup
e17b095
@BradWhitlock
Hook up polyhedral zone extraction
78b112e
@BradWhitlock
make style
85c210d
@BradWhitlock BradWhitlock marked this pull request as draft April 11, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BradWhitlock