[Compiler plugin] join operations support #1139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
added
the
Compiler plugin
koperagen
changed the title
koperagen
force-pushed
the
compiler-plugin-join-support
branch
from
ee9ea15 to
2a17323
Compare
koperagen
force-pushed
the
compiler-plugin-join-support
branch
from
2a17323 to
bccd01e
Compare
zaleslaw
reviewed
Apr 23, 2025
| // This checks that schemas have same set of columns, but compile time columns can be nullable where runtime is narrowed to non-nullable | ||
|
|
||
| sealed interface Mismatch | ||
| data class AcceptableMismatch(val path: ColumnPath, val compile: KType, val runtime: KType) : Mismatch |
There was a problem hiding this comment.
Probably the nullability fact could be somehow reflected in naming, like NullabilityMismatch or something like this
zaleslaw
reviewed
Apr 23, 2025
| "Charlie", 30, "Moscow", 90, | ||
| ) | ||
|
|
||
| val typed2 = dataFrameOf("name", "origin", "grade", "age")( |
There was a problem hiding this comment.
Probably we need here one test for nested tables and their joins
zaleslaw
reviewed
Apr 23, 2025
|
|
||
| internal data class ColumnMatchApproximation(val left: ColumnsResolver, val right: ColumnsResolver) | ||
| internal data class ColumnMatchApproximation( |
There was a problem hiding this comment.
Could you give me a hint, what does Approximation mean. I see a lot in naming, but could not understand the idea
zaleslaw
reviewed
Apr 23, 2025
| } | ||
|
|
||
| internal class ColumnListImpl<C>(override val columns: List<ColumnsResolver<C>>) : | ||
| ColumnSet<C>, |
There was a problem hiding this comment.
wow, formatting looks weird to me
There was a problem hiding this comment.
Unfortunately this is the only way the linter allows it
zaleslaw
requested changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In first commit i adapted
ColumnMatchandColumnListto embed them into compiler plugin column resolving mechanismNew util functions designed to make sure all column names generated by compiler plugin in join are exactly as in runtime, and make sure there are no missing columns. They can however sometimes have nullability where runtime narrows the type to non-nullable