Skip to content

Fix stream return value getting disposed #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2020

Conversation

JeremyTCD
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 22, 2020

Codecov Report

Merging #73 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   97.52%   97.52%   +<.01%     
==========================================
  Files          18       18              
  Lines         565      566       +1     
==========================================
+ Hits          551      552       +1     
  Misses         14       14
Impacted Files Coverage Δ
...ementations/OutOfProcess/Http/HttpNodeJSService.cs 96.77% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6db186...37acd8a. Read the comment docs.

@JeremyTCD JeremyTCD force-pushed the Fix_stream_return_value_getting_disposed branch from 206e934 to 161d6c9 Compare February 22, 2020 04:14
@JeremyTCD JeremyTCD force-pushed the Fix_stream_return_value_getting_disposed branch from b19fe42 to 37acd8a Compare February 22, 2020 05:58
@JeremyTCD JeremyTCD merged commit 1e7e55c into master Feb 22, 2020
@JeremyTCD JeremyTCD deleted the Fix_stream_return_value_getting_disposed branch February 22, 2020 06:21
@JeremyTCD
Copy link
Member Author

🚀 Released 5.3.2 with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example of returning a stream? Result.stream is undefined
1 participant