Skip to content

Fix TryCreateMessage empty data #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 25, 2019
Merged

Fix TryCreateMessage empty data #55

merged 6 commits into from
Nov 25, 2019

Conversation

JeremyTCD
Copy link
Member

#54

@JeremyTCD JeremyTCD force-pushed the fix-trycreatemessage-empty-data branch from a112a07 to 8d1cb1b Compare November 25, 2019 05:11
@JeremyTCD JeremyTCD mentioned this pull request Nov 25, 2019
Closed
@codecov
Copy link

codecov bot commented Nov 25, 2019 •
edited
Loading

Codecov Report

Merging #55 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   97.82%   97.84%   +0.02%     
==========================================
  Files          17       17              
  Lines         505      511       +6     
==========================================
+ Hits          494      500       +6     
  Misses         11       11
Impacted Files Coverage Δ
...ntations/OutOfProcess/OutOfProcessNodeJSService.cs 99.31% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd57f7...423b168. Read the comment docs.

@JeremyTCD JeremyTCD force-pushed the fix-trycreatemessage-empty-data branch from b8729de to eedf56a Compare November 25, 2019 05:52
@JeremyTCD
Avoid exception if data length is 0
b01e51e 
- We can't just ignore data if its length is 0. If JS calls console.log('a\n\nb'), we receive "a", "" and "b", where "" denotes an empty line between "a" and "b".
@JeremyTCD
Added release 4.4.1.
5216236
@JeremyTCD JeremyTCD force-pushed the fix-trycreatemessage-empty-data branch from eedf56a to 5216236 Compare November 25, 2019 06:01
@JeremyTCD JeremyTCD merged commit 4661c99 into master Nov 25, 2019
@JeremyTCD JeremyTCD deleted the fix-trycreatemessage-empty-data branch November 25, 2019 06:11
@JeremyTCD JeremyTCD linked an issue Apr 2, 2020 that may be closed by this pull request
App crash on large number of errors #54
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App crash on large number of errors
1 participant
@JeremyTCD