Remove duplicate AuthenticationManager definition #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously SimpleUsernamePasswordAuthFilter had a separate reference to an AuthenticationManager from the one defined in UsernamePasswordAuthenticationFilter. This means there was an unused variable in UsernamePasswordAuthenticationFilter. It also meant that SimpleUsernamePasswordAuthFilter.setAuthenticationManager was setting an AuthenticationManager that wasn't used for authenticating. This removes the unnecessary AuthenticationMnaager and instead sets the UsernamePasswordAuthenticationFilter instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously SimpleUsernamePasswordAuthFilter had a separate reference to an
AuthenticationManager from the one defined in
UsernamePasswordAuthenticationFilter. This means there was an unused
variable in UsernamePasswordAuthenticationFilter. It also meant that
SimpleUsernamePasswordAuthFilter.setAuthenticationManager was setting an
AuthenticationManager that wasn't used for authenticating.
This removes the unnecessary AuthenticationMnaager and instead sets the
UsernamePasswordAuthenticationFilter instance.