Run the Windows MSRV checks on Server 2022 #1515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of this commit, `ubuntu-latest` is `ubuntu-22.04`, with the `ubuntu-24.04` runner image having beta status (even though Ubuntu 24.04 LTS is released), and `windows-latest` is `windows-2022`. So this is putting Ubuntu back to 22.04, but it will automatically become 24.04 evenutally, which the previous commit checks is likely to work (since it would work now). As detailed in GitoxideLabs#1514, there have not been problems in the past with new Ubuntu versions on GHA runners breaking this workflow. In contrast, there have been such problems with the Windows runners, so this keeps the pin adjusted to the newer version, but it does not change it to rolling.
Byron
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Windows runner from
windows-2019towindows-2022. Althoughwindows-2022is also what one currently gets forwindows-latest, this uses the specific label for that. This is as discussed in, and for the reason noted in, #1514.The first commit checks that Ubuntu 24.04 LTS will work when
ubuntu-latestmoves fromubuntu-22.04toubuntu-24.04. That worked fine, as I expected. As also noted in #1514, using the rolling Ubuntu runner OS version hasn't caused problems in the past, so this puts it back in the second commit, leaving only the bumping of the Windows runner version. That's what's going on with having two commits instead of one for a two-character change 😄.