Add YAML loading options to mirror ActiveRecord behavior #889
+20
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Looks good. Could you add specs for the new config options? It seems to me the proper place for new tests is https://github.com/Dynamoid/dynamoid/blob/master/spec/dynamoid/dumping_spec.rb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in #757, adds two new options that allow YAML safe loading behavior to be customized or disabled.
Because there is a lot of different behavior between versions of the Pysch gem, we should directly check what methods are available instead of the Ruby version (particularly because newer Ruby versions can still run older versions of Pysch).