Provide a non-watch way of running tests locally #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Locally, when I run test, I get the coverage report however it continues to watch. The way the react-scripts is setup the watch flag is not used when running on CI such that CI does not hang. It is recommended by the facebook folks that we set that env flag when we want to run non watch test. See here facebook/create-react-app#784 |
bmatto
suggested changes
Feb 3, 2017
app/templates/package.json
Outdated
| @@ -35,7 +35,8 @@ | |||
| "scripts": { | |||
| "start": "react-scripts start", | |||
| "build": "react-scripts build", | |||
| "test": "react-scripts test --env=jsdom", | |||
| "test": "react-scripts test --env=jsdom --coverage", | |||
There was a problem hiding this comment.
Add CI=true at the beginning of this line
randycoulman
force-pushed
the
non-watch-testing
branch
from
65cd2e3 to
9399336
Compare
bmatto
approved these changes
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
yarn validatelocally, we want the tests to run once and stop, butyarn testruns in watch mode.This PR adds a
test:oncescript that:a) sets the
CIenvironment variable, which is the recommended way of disabling watch mode.b) sets the
—coverageflag so that we can see our code coverage information when running the tests.Fixes #24