[Fusion] Add support for result from different subgraph on interfaces #8293
+169
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed checks seem unrelated to me, the Fusion.CommandLine test failed before on the main-version-15 branch. |
tobias-tengler
approved these changes
May 19, 2025
|
Thank you for the contribution 😊 |
src/HotChocolate/Fusion/src/Core/Planning/Pipeline/ExecutionStepDiscoveryMiddleware.cs
Outdated
Show resolved
Hide resolved
michaelstaib
changed the base branch from
main-version-15
to
fusion-15-interface-fix
michaelstaib
merged commit 8607cec
into
ChilliCream:fusion-15-interface-fix
100 of 104 checks passed
|
Thanks you for the contribution, @Enterprize1! 🚀 Preview version 15.1.6-p.1 should be available on NuGet in about 15–20 minutes. If you haven’t already, feel free to join our Slack community and say hello! 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7365.
When requesting a result from a different subgraph on an interface with multiple implementing types the request to the second subgraph was planned multiple times (once for each implementing type). This lead the compose-step to return null for the data from the second subgraph as the data was requested and added multiple times for each object returned by the interface list.
(Hope that explains the problem, if not maybe comparison of the query plan for the test I added before and after the change in ExecutionStepDiscoveryMiddleware.cs could provide some clarification :) )
Now only a single request to the second subgraph is planned for all types implementing the interface by deduplicating the contents of the backlog during execution step discovery.