Skip to content

feat: select early muxer #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

feat: select early muxer #482

merged 1 commit into from
Mar 20, 2025

Conversation

achingbrain
Copy link
Collaborator

Implements early multiplexer negotiation to save multistream-select round trips when a connection is opened.

Spec: https://github.com/libp2p/specs/blob/6d38f88f7b2d16b0e4489298bcd0737a6d704f7e/connections/inlined-muxer-negotiation.md#multiplexer-negotiation-over-noise

@achingbrain achingbrain requested a review from wemeetagain March 4, 2025 07:34
@achingbrain achingbrain requested a review from a team as a code owner March 4, 2025 07:34
@achingbrain achingbrain force-pushed the feat/select-early-muxer branch from d2275ef to ac4f5d5 Compare March 4, 2025 07:39
achingbrain added a commit to libp2p/js-libp2p that referenced this pull request Mar 6, 2025
achingbrain added a commit to libp2p/js-libp2p that referenced this pull request Mar 6, 2025
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this feature backwards compatible?

for example, if the client sends muxers, but the server doesn't recognize this feature yet, will the handshake succeed?

@achingbrain
Copy link
Collaborator Author

Yes, if no muxer is agreed on using early data, the peers will fall back to using multistream-select to negotiate the muxer.

@wemeetagain wemeetagain merged commit 58c9fb9 into master Mar 20, 2025
18 checks passed
@wemeetagain wemeetagain deleted the feat/select-early-muxer branch March 20, 2025 14:35
wemeetagain pushed a commit that referenced this pull request Mar 20, 2025
## [16.1.0](v16.0.3...v16.1.0) (2025-03-20)

### Features

* select early muxer ([#482](#482)) ([58c9fb9](58c9fb9))
@wemeetagain
Copy link
Member

🎉 This PR is included in version 16.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants