-
-
Notifications
You must be signed in to change notification settings - Fork 704
[geolocator_apple] Add swift package manager compatibility #1630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[geolocator_apple] Add swift package manager compatibility #1630
Conversation
…into swift-package-manager-compatibility
…into swift-package-manager-compatibility
Hey @TimHoogstrate, any chance this PR could be reviewed soon? Thanks! |
…into swift-package-manager-compatibility # Conflicts: # geolocator_apple/CHANGELOG.md # geolocator_apple/macos/geolocator_apple.podspec
Thanks @alejandro-all-win-software for the contribution. I'm currently reviewing your work. It looks good to me, but what would be the best approach to test this? Kind regards, |
Hey @TimHoogstrate, if you’re referring to just testing the integration, you can enable SPM for Flutter using the following command:
This is mentioned in the Flutter documentation. If you mean testing it in workflows, we could take a similar approach to |
Oke, i've tested this and it seems to work as expected. You also renamed iOS (and macOS) to Darwin, seems logical to me but @mvanbeusekom what do you think of it? |
Google names the platform specific implementations after the SDK that is being used. Some examples:
The reason they do this is that they can easily add more implementations when Apple introduces a new SDK. Working closely together with the Google team I like this convention. Which mean for the geolocator I would prefer the name |
@mvanbeusekom, should I rename the package from |
Yes, if we are renaming that would be my preference. That way we'll stay close to Google's take on naming packages for the Apple platforms.otherwise I don't really see a need to rename |
Hmm, I didn't rename the entire package to |
Sorry for the confusion, I was working from my mobile phone and didn't complete get the whole picture/ context. In this case I am fine with renaming the folder to @TimHoogstrate, this looks good to me and can be merged. |
* chore: added swift package manager compatibility * chore: bump pubspec version * chore: added ephemeral to gitignore
Makes
geolocator_apple
available as a Swift Package to FlutterCloses #1629
Pre-launch Checklist
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.md
to add a description of the change.///
).main
.dart format .
and committed any changes.flutter analyze
and fixed any errors.