revert: [NPM] [v1.5] Remove hostUsers Configuration #3614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed all logs from npm dataplane (except error/warning logs) * removed all logs from npm controller (except error/warning logs) * restored logs that are ununused by current npm (v2) * removed test files * resolved comments * keep log related to reconciling chain placement when the chain is not in the right place * added bootup logs back * Removed two more noisy logs * Add loglevel config option when printing application insight logs * Updated all non-error/warning logs to commented out and with a vap TODO * fixed typo * small typo fix * updated configmap with loglevel * updated default value * added a default value for loglevel * fixed typo in json * removed comma * changed loglevel to info in configmap * add a short sleep in TestNetPolInBackgroundSkipAddAfterRemove * test remove dataplane changes to see if race condition fixes * Revert "test remove dataplane changes to see if race condition fixes" This reverts commit 08697eb. * test * Revert "test" This reverts commit 449c2af. * test * update dataplane to test if changes are flagged in race * added stop channels to unit tests to avoid race condtiions * add non noisy logs back * increased time * revert time change after RunPeriodicTasks * test with 1000 seconds * 5000 milliseconds * tweaked the delay * update to 1500 for defer * increased to 1500 * increase to 2000 * removed kubernetes
There was a problem hiding this comment.
Pull Request Overview
This PR removes the now-unnecessary hostUsers setting from the NPM daemonset as the use of other host namespaces is disallowed when a user namespace is in use.
- Removed hostUsers: false property from the daemonset configuration
- Aligns the NPM configuration with Kubernetes user namespace limitations
rayaisaiah
changed the title
|
/azp run Azure Container Networking PR |
|
/azp run NPM Conformance Tests |
|
/azp run NPM Scale Test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
huntergregory
previously approved these changes
Apr 29, 2025
rayaisaiah
changed the title
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
huntergregory
approved these changes
May 1, 2025
npm lite isnt on release/v1.5 but i did remove it from master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Removes the
hostUsers: falsesetting in the NPM daemonset. Reverts from changes #2589Also adds a public-ip and service tag to NPM scale and conformance tests to comply with SFI rules (failing with
RequestDisallowedByPolicyotherwise).Issue Fixed:
From https://kubernetes.io/docs/concepts/workloads/pods/user-namespaces/#limitations
When using a user namespace for the pod, it is disallowed to use other host namespaces. In particular, if you set
hostUsers: falsethen you are not allowed to set any of:Requirements:
Notes: