Skip to content

chore: Set up semantic release #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 13, 2020
Merged

chore: Set up semantic release #1332

merged 9 commits into from
Jun 13, 2020

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Jun 12, 2020

As discussed on Slack and in #1331, this PR removes our custom release logic, including publishing nightlies which isn't necessary anymore after the change, and installs semantic-release (currently configured to perform dry runs in case something goes wrong).

Commit format would then be:

  • fix: Message for a patch (wondering what will happen there with version < 1)
  • feat: Message for a minor
  • BREAKING CHANGE: Message (or used as a footer) for a major
  • I've read the contributing guidelines

@dcodeIO
Copy link
Member Author

dcodeIO commented Jun 12, 2020

Looking up the v0 problem revealed that they are apparently not handling v0.x.x as one would expect, but will bump to v1.0.0 on the next breaking change. Quite unfortunate.

@MaxGraey
Copy link
Member

Btw it seems it could be with optional scope like:
fix(parser): message
feat(std): message
In this case will be great have whole list of conventions

@dcodeIO
Copy link
Member Author

dcodeIO commented Jun 12, 2020

Yeah, using a scope seems good. I'm however unwilling to force out a v1 just because of this. Now one could argue that version numbers are arbitrary anyway, but I guess if there is a case to be made about something being "not quite ready" to be a v1.0.0, then it's in tech like WebAssembly, so I'd like to stick to v0.x.x for now.

@dcodeIO dcodeIO marked this pull request as draft June 12, 2020 21:26
@dcodeIO
Copy link
Member Author

dcodeIO commented Jun 13, 2020

Now uses my fork of semantic-release that has a --unstable command line option enforcing releases to stay in the v0.x.y range. Turned out this can be achieved with just a few lines of code.

@dcodeIO dcodeIO changed the title Set up semantic release chore: Set up semantic release Jun 13, 2020
@dcodeIO dcodeIO marked this pull request as ready for review June 13, 2020 05:42
@dcodeIO
Copy link
Member Author

dcodeIO commented Jun 13, 2020

Merging, but letting it perform dry runs initially so I can check the logs, hence no actual releases just yet. Going to activate once sufficiently confident that it's working :)

@dcodeIO dcodeIO merged commit 085aa7f into master Jun 13, 2020
@dcodeIO dcodeIO deleted the semantic-release branch July 16, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants