make Pod derive from Any #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax0
reviewed
Apr 22, 2025
src/backends/plonky2/mainpod/mod.rs
Outdated
Comment on lines
296
to
298
| let p = (*p as &dyn Any).downcast_ref::<SignedPod>() | ||
| .expect("type SignedPod"); |
There was a problem hiding this comment.
Suggested change
| let p = (*p as &dyn Any).downcast_ref::<SignedPod>() | |
| .expect("type SignedPod"); | |
| let p = (*p as &dyn Any) | |
| .downcast_ref::<SignedPod>() | |
| .expect("type SignedPod"); |
cf. cargo fmt --check.
ax0
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes Pod inherit Any, which removes the need for the as_any and into_any functions.
It requires the
trait_upcastingfeature, which was considered experimental in thenightly-2025-01-20toolchain, but has since been stabilized: rust-lang/rust#65991