Prevent NPE on empty commit (go-gitea#16812)

zeripath · zeripath · commit ce4d290cd971 · 2021-08-25T09:09:28.000+01:00
Backport go-gitea#16812 Handle completely empty commit as the first commit to a repository. Fix go-gitea#16668 Signed-off-by: Andrew Thornton art27@cantab.net
diff --git a/modules/git/log_name_status.go b/modules/git/log_name_status.go
@@ -167,6 +167,9 @@ func (g *LogNameStatusRepoParser) Next(treepath string, paths2ids map[string]int
 				return nil, err
 			}
 		}
+		if len(g.next) == 0 {
+			return &ret, nil
+		}
 		if g.next[0] == '\x00' {
 			g.buffull = false
 			g.next, err = g.rd.ReadSlice('\x00')

Original file line number	Diff line number	Diff line change
`@@ -167,6 +167,9 @@ func (g *LogNameStatusRepoParser) Next(treepath string, paths2ids map[string]int`
`167`	`167`	`return nil, err`
`168`	`168`	`}`
`169`	`169`	`}`
	`170`	`+ if len(g.next) == 0 {`
	`171`	`+ return &ret, nil`
	`172`	`+ }`
`170`	`173`	`if g.next[0] == '\x00' {`
`171`	`174`	`g.buffull = false`
`172`	`175`	`g.next, err = g.rd.ReadSlice('\x00')`