Skip to content

slow hypothesis tests are too slow #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
d-v-b opened this issue Apr 23, 2025 · 3 comments
Open

slow hypothesis tests are too slow #3010

d-v-b opened this issue Apr 23, 2025 · 3 comments
Labels
help wanted Issue could use help from someone with familiarity on the topic

Comments

@d-v-b
Copy link
Contributor

d-v-b commented Apr 23, 2025

see https://github.com/zarr-developers/zarr-python/actions/runs/14613337704/job/41002901719#step:7:296, this test was running for 20+ minutes and failed. Something has changed about the test itself or our deployment of test resources. Either way we should fix it.
@d-v-b d-v-b added the help wanted Issue could use help from someone with familiarity on the topic label Apr 23, 2025
@d-v-b d-v-b mentioned this issue Apr 24, 2025
Open
@TomAugspurger
Copy link
Contributor

HypothesisWorks/hypothesis#4364 noted a performance regression in hypothesis. Not sure what version that was but IIRC it's fixed now.

We might want to use something like pytest-timeout to limit the runtime of those tests regardless.

This was referenced May 1, 2025
Open
Open
@dstansby
Copy link
Contributor

dstansby commented May 7, 2025

Currently running at > 30 mins and counting over at https://github.com/zarr-developers/zarr-python/actions/runs/14883916292/job/41798353654?pr=3041. Would be great if someone can think of a way to speed up the hypothesis tests.

@dcherian
Copy link
Contributor

dcherian commented May 7, 2025

I can take a look next week. One option is to run the stateful tests (which are the slowest one) only nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issue could use help from someone with familiarity on the topic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TomAugspurger @dcherian @d-v-b @dstansby