Skip to content

Ruff conflicts with pep8 #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
normanrz opened this issue May 6, 2024 · 5 comments · Fixed by #1890
Closed

Ruff conflicts with pep8 #1841

normanrz opened this issue May 6, 2024 · 5 comments · Fixed by #1890
Milestone

Comments

@normanrz
Copy link
Member

normanrz commented May 6, 2024

In this PR #1839 I have a conflict where the @pep8speaks bot is in conflict with the ruff formatter.
PEP8 comment: #1839 (comment)
Ruff pre-commit: https://results.pre-commit.ci/run/github/48049137/1715025400.r2onHl8LSX240CJ0_K4lOw

The difference is illustrated in this commit: d8b5ca7

@jhamman jhamman added the V3 label May 7, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone May 7, 2024
@jhamman
Copy link
Member

jhamman commented May 7, 2024

I would be in favor of removing the pep8speaks bot in favor of strict Ruff rules (similar to what are being applied in #1702).

@jhamman jhamman moved this to Todo in Zarr-Python - 3.0 May 7, 2024
@jhamman
Copy link
Member

jhamman commented May 11, 2024

@MSanKeys963 - I don't have privileges to turn off pep8speaks here. Can you do that for us?

@sanketverma1704
Copy link
Member

Hi @jhamman. I just checked, and my privileges are the same as yours and ZP core developers.
@joshmoore, can you help us here?

@joshmoore
Copy link
Member

joshmoore commented May 11, 2024

Here are the installed apps:

image

I've "suspended" pep8speaks. Let's see if that does the right thing. (I've also removed travis)

At one of the first core devs meetings, let's go through permissions and set things up correctly.

@normanrz
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants