add tests

Author: wagoodman

.circleci/config.yml

@@ -22,7 +22,7 @@ jobs:
             - "/go/pkg/mod"
       - run:
           name: run static analysis
-          command: make ci-static-analyses
+          command: make ci-static-analysis
 
   run-tests:
     parameters:

.github/workflows/pipeline.yml

@@ -64,7 +64,7 @@ jobs:
         run: go get ./...
 
       - name: Linting, formatting, and other static code analyses
-        run: make ci-static-analyses
+        run: make ci-static-analysis
 
       - name: Build snapshot artifacts
         run: make ci-build-snapshot-packages

Makefile

@@ -12,7 +12,7 @@ all: clean build
 ci-unit-test:
 	go test -cover -v -race ./...
 
-ci-static-analyses:
+ci-static-analysis:
 	grep -R 'const allowTestDataCapture = false' runtime/ui/viewmodel
 	go vet ./...
 	@! gofmt -s -l . 2>&1 | grep -vE '^\.git/' | grep -vE '^\.cache/'

runtime/ui/app.go

@@ -44,6 +44,10 @@ func newApp(gui *gocui.Gui, analysis *image.AnalysisResult, cache filetree.Compa
 		lm.Add(compound.NewLayerDetailsCompoundLayout(controller.views.Layer, controller.views.Details), layout.LocationColumn)
 		lm.Add(controller.views.Tree, layout.LocationColumn)
 
+		// todo: access this more programmatically
+		if debug {
+			lm.Add(controller.views.Debug, layout.LocationColumn)
+		}
 		gui.Cursor = false
 		//g.Mouse = true
 		gui.SetManagerFunc(lm.Layout)

runtime/ui/layout/manager.go

@@ -113,7 +113,7 @@ func (lm *Manager) planAndLayoutColumns(g *gocui.Gui, area Area) (Area, error) {
 			}
 		}
 
-		defaultWidth := int(availableWidth / variableColumns)
+		defaultWidth := availableWidth / variableColumns
 
 		// second pass: layout columns left to right (based off predetermined widths)
 		for idx, element := range elements {
@@ -177,18 +177,22 @@ func (lm *Manager) notifyLayoutChange() error {
 	return nil
 }
 
+func (lm *Manager) Layout(g *gocui.Gui) error {
+	curMaxX, curMaxY := g.Size()
+	return lm.layout(g, curMaxX, curMaxY)
+}
+
 // layout defines the definition of the window pane size and placement relations to one another. This
 // is invoked at application start and whenever the screen dimensions change.
 // A few things to note:
 //  1. gocui has borders around all views (even if Frame=false). This means there are a lot of +1/-1 magic numbers
 //     needed (but there are comments!).
 //  2. since there are borders, in order for it to appear as if there aren't any spaces for borders, the views must
 //     overlap. To prevent screen artifacts, all elements must be layedout from the top of the screen to the bottom.
-func (lm *Manager) Layout(g *gocui.Gui) error {
+func (lm *Manager) layout(g *gocui.Gui, curMaxX, curMaxY int) error {
 	var headerAreaChanged, footerAreaChanged, columnAreaChanged bool
 
-	// grab the latest screen size and compare with the last layout
-	curMaxX, curMaxY := g.Size()
+	// compare current screen size with the last known size at time of layout
 	area := Area{
 		minX: -1,
 		minY: -1,