Skip to content

clarify Request.isReload for sub-resources #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wanderview opened this issue Jan 29, 2016 · 2 comments
Closed

clarify Request.isReload for sub-resources #827

wanderview opened this issue Jan 29, 2016 · 2 comments

Comments

@wanderview
Copy link
Member

Current the spec text for .isReload is a bit vague. Step 18.4 of Handle Fetch says:

Let the isReload attribute of e be initialized to true if request's client is a window client and the event was dispatched with the user's intention for the page reload, and false otherwise.

Obviously a lot of hand waving in "user's intention" here.

Both chrome and firefox only set this for the top level navigation that is triggered from a refresh. All sub-resources get .isReload=false.

Over in this chrome issue devs are asking that to change:

https://code.google.com/p/chromium/issues/detail?id=579866

But its unclear to me what this means for subresources. I see some possibilities:

  1. All sub-resources loaded synchronously during reload get .isReload = true
  2. Sub-resources loaded sync and async before load event get .isReload = true
  3. Sub-resources from a reloaded document always get .isReload = true even if they are async requested an hour later, etc.

I think (1) or (2) make the most sense for developers. Thoughts?

@mitar
Copy link

mitar commented Jan 29, 2016

I agree, 1) or 2) would be great. My main view here is that user reload the whole page, not just the HTML content. So they would expect that the all resources on that page (can) react to the reload (in a special way).

@jakearchibald
Copy link
Contributor

Closing this as we're dropping isReload #873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants