-
-
Notifications
You must be signed in to change notification settings - Fork 354
Proposal: drop support to python 2.7 #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@domdinicola might be a good idea, thanks! Although would be interested to get familiar with runtime usage statistics. p.s. and might be slow with response since on vacation until the end of the month |
based on this https://en.wikipedia.org/wiki/History_of_Python we should be able to get rid of those since are not officially supported anymore. |
Here's the pip installs for Office365-REST-Python-Client from PyPI for June 2020:
Source: |
Since between 3.6 and 3.7 we reach more than 90%, I think we can drop 3.5 and 2.7 (3.4 is already not supported) |
This is probably a good time to drop Python 2:
|
@domdinicola still interested to work this? (It's hacktoberfest after all 😉) I've done some typing improvements (#747) and will try to get the most of the static checks passing. Once passing, it's probably a good time to do this. The new typing format is very similar to what we'll use in Python 3, but since it's still supported in Python 3 we don't have to convert everything in one PR. To keep it smaller, probably removing @vgrem suggested to move to v 3.0.0 of the library |
@kellerza agree, if needed I could help with this. |
If @vgrem you agree I can create a PR to address this
The text was updated successfully, but these errors were encountered: