Skip to content

Fix static_href when url has = #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

Fix static_href when url has = #244

merged 1 commit into from
May 2, 2025

Conversation

george-gca
Copy link
Collaborator

🔤 Polyglot PR

Fixed #243

add a sweet (optional) meme

Type of change

  • Docs update (changes to the readme or a site page, no code changes)
  • Ops wrangling (automation or test improvements)
  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Sweet release (needs a lot of work and effort)
  • Something else (explain please)

Checklists

  • If modifying code, at least one test has been added to the suite

Not sure if we need more tests for this, but it could be a good idea.

@untra
Copy link
Owner

untra commented May 2, 2025

Nice fix! Thanks again 😁

@untra untra merged commit e7f818d into untra:master May 2, 2025
1 check passed
@george-gca george-gca deleted the fix_static_href branch May 2, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untra untra untra approved these changes

Assignees

@untra untra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

static_href does not work when href value contains ? querystring param
2 participants
@george-gca @untra