Skip to content

Implement Eq and maybe Ord for AugmentScriptSet #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crlf0710 opened this issue May 30, 2020 · 2 comments
Closed

Implement Eq and maybe Ord for AugmentScriptSet #15

crlf0710 opened this issue May 30, 2020 · 2 comments

Comments

@crlf0710
Copy link
Collaborator

Eq is necessary for using in hashmaps, and for rustc reproducible builds, it will be even better if it can also implement Ord so we can use it in BTreeMap.
@crlf0710 crlf0710 mentioned this issue May 30, 2020
Merged
@crlf0710
Copy link
Collaborator Author

Eq is added in #17 . Not sure yet about the Ord part, maybe we can see whether we can sort the Span instead as a workaround.

@crlf0710
Copy link
Collaborator Author

crlf0710 commented Jul 1, 2020

It turns on Ord part is not needed. closing.

@crlf0710 crlf0710 closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crlf0710