From cfd4d53fc6cc03d0261aa957e4cf2e0404aa37ba Mon Sep 17 00:00:00 2001 From: Dan Freeman Date: Wed, 5 Sep 2018 14:34:09 -0400 Subject: [PATCH] Use devDependencies for in-repo dummy addons. The new PackageInfoCache stuff in ember-cli@3.4 complains loudly about missing packages in our published `paths` entry. --- package.json | 8 +++----- tests/dummy/lib/in-repo-a/package.json | 3 ++- tests/dummy/lib/in-repo-b/package.json | 3 ++- tests/dummy/lib/in-repo-c/package.json | 3 ++- yarn.lock | 16 ++++++++++++++++ 5 files changed, 25 insertions(+), 8 deletions(-) diff --git a/package.json b/package.json index 35e223b41..d6c289bab 100644 --- a/package.json +++ b/package.json @@ -81,6 +81,9 @@ "eslint-plugin-ember": "^5.0.3", "eslint-plugin-node": "^6.0.1", "esprima": "^4.0.0", + "in-repo-a": "link:tests/dummy/lib/in-repo-a", + "in-repo-b": "link:tests/dummy/lib/in-repo-b", + "in-repo-c": "link:tests/dummy/lib/in-repo-c", "loader.js": "^4.2.3", "mktemp": "^0.4.0", "mocha": "^5.0.0", @@ -97,11 +100,6 @@ "configPath": "tests/dummy/config", "before": [ "ember-cli-babel" - ], - "paths": [ - "tests/dummy/lib/in-repo-a", - "tests/dummy/lib/in-repo-b", - "tests/dummy/lib/in-repo-c" ] }, "prettier": { diff --git a/tests/dummy/lib/in-repo-a/package.json b/tests/dummy/lib/in-repo-a/package.json index f2080896a..9280d654a 100644 --- a/tests/dummy/lib/in-repo-a/package.json +++ b/tests/dummy/lib/in-repo-a/package.json @@ -1,10 +1,11 @@ { "name": "in-repo-a", + "version": "1.0.0", "keywords": [ "ember-addon" ], "dependencies": { - "ember-cli-babel": "*" + "ember-cli-babel": "link:../../../../node_modules/ember-cli-babel" }, "devDependencies": { "ember-cli-typescript": "*" diff --git a/tests/dummy/lib/in-repo-b/package.json b/tests/dummy/lib/in-repo-b/package.json index 52f7b0903..80160144e 100644 --- a/tests/dummy/lib/in-repo-b/package.json +++ b/tests/dummy/lib/in-repo-b/package.json @@ -1,10 +1,11 @@ { "name": "in-repo-b", + "version": "1.0.0", "keywords": [ "ember-addon" ], "dependencies": { - "ember-cli-babel": "*" + "ember-cli-babel": "link:../../../../node_modules/ember-cli-babel" }, "devDependencies": { "ember-cli-typescript": "*" diff --git a/tests/dummy/lib/in-repo-c/package.json b/tests/dummy/lib/in-repo-c/package.json index c475f8aab..6b50f66e2 100644 --- a/tests/dummy/lib/in-repo-c/package.json +++ b/tests/dummy/lib/in-repo-c/package.json @@ -1,10 +1,11 @@ { "name": "in-repo-c", + "version": "1.0.0", "keywords": [ "ember-addon" ], "dependencies": { - "ember-cli-babel": "*" + "ember-cli-babel": "link:../../../../node_modules/ember-cli-babel" }, "devDependencies": { "ember-cli-typescript": "*" diff --git a/yarn.lock b/yarn.lock index e406419e8..26f2ec8bd 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2488,6 +2488,10 @@ ember-cli-babel@^6.0.0-beta.4, ember-cli-babel@^6.0.0-beta.7, ember-cli-babel@^6 ember-cli-version-checker "^2.1.0" semver "^5.4.1" +"ember-cli-babel@link:node_modules/ember-cli-babel": + version "0.0.0" + uid "" + ember-cli-blueprint-test-helpers@^0.18.3: version "0.18.3" resolved "https://registry.yarnpkg.com/ember-cli-blueprint-test-helpers/-/ember-cli-blueprint-test-helpers-0.18.3.tgz#945c606d855f0263f5e8c03522e4040a74f259cc" @@ -4120,6 +4124,18 @@ imurmurhash@^0.1.4: version "0.1.4" resolved "https://registry.yarnpkg.com/imurmurhash/-/imurmurhash-0.1.4.tgz#9218b9b2b928a238b13dc4fb6b6d576f231453ea" +"in-repo-a@link:tests/dummy/lib/in-repo-a": + version "0.0.0" + uid "" + +"in-repo-b@link:tests/dummy/lib/in-repo-b": + version "0.0.0" + uid "" + +"in-repo-c@link:tests/dummy/lib/in-repo-c": + version "0.0.0" + uid "" + indent-string@^2.1.0: version "2.1.0" resolved "https://registry.yarnpkg.com/indent-string/-/indent-string-2.1.0.tgz#8e2d48348742121b4a8218b7a137e9a52049dc80"