Skip to content

Install @types/ember-data__* by default #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NullVoxPopuli opened this issue Feb 29, 2020 · 7 comments
Closed

Install @types/ember-data__* by default #1109

NullVoxPopuli opened this issue Feb 29, 2020 · 7 comments

Comments

@NullVoxPopuli
Copy link
Collaborator

This is a reminder issue, for https://discordapp.com/channels/480462759797063690/484421406659182603/683369672594292750

at the moment, @ember-data/ types are not installed

@makepanic
Copy link

Is there a plan on where to do this?
Should DefinitelyTyped ship them?

I think I might have some time to port the existing types to @ember-data/* as it's kinda blocking the ember/use-ember-data-rfc-395-imports linting rule.

@chriskrycho
Copy link
Member

@makepanic these exist on Definitely Typed now (and have since the end of January) – this issue is tracking installing them by default.

@chriskrycho chriskrycho changed the title Add new types package: @ember-data/* Install @types/ember-data__* by default Apr 8, 2020
@chriskrycho
Copy link
Member

To elaborate the above – if anyone is interested in doing this, all you have to do is update the existing implementation here and the tests.

The key for updating the existing implementation is that we should use version checker to make sure we only do it if users have installed a version of Ember Data which supports the exports. @runspired @rwjblue I believe you looked at making the Babel polyfill for the modules work back a ways – did that happen, and if so, how far back?

@Bouke
Copy link
Contributor

Bouke commented Jun 24, 2020

If people are wondering what to install manually, I think this is the list:

  • @types/ember-data__adapter
  • @types/ember-data__model
  • @types/ember-data__serializer
  • @types/ember-data__store

@karbica
Copy link

karbica commented Jul 30, 2020

@Bouke Thanks for that list. Is there an official list of other packages to install manually after installing ember-cli-typescript?

I'm getting errors import from modules that I didn't get before moving to TypeScript. One example is from @ember-data/model.

@MrChocolatine
Copy link
Contributor

MrChocolatine commented Feb 12, 2021

Edit: I did not see the linked pull request.

I am reviving this issue, should we add these new types to the blueprint?

let packages = [
'typescript',
'ember-cli-typescript-blueprints',
'@types/ember-resolver',
'@types/ember__test-helpers',
'@types/ember__object',
'@types/ember__service',
'@types/ember__controller',
'@types/ember__string',
'@types/ember__template',
'@types/ember__polyfills',
'@types/ember__utils',
'@types/ember__runloop',
'@types/ember__debug',
'@types/ember__engine',
'@types/ember__application',
'@types/ember__test',
'@types/ember__array',
'@types/ember__error',
'@types/ember__component',
'@types/ember__routing',
'@types/rsvp',
'@types/htmlbars-inline-precompile',
];

@jamescdavis
Copy link
Member

Fixed in #1411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants