-
Notifications
You must be signed in to change notification settings - Fork 99
Install @types/ember-data__* by default #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is there a plan on where to do this? I think I might have some time to port the existing types to |
@makepanic these exist on Definitely Typed now (and have since the end of January) – this issue is tracking installing them by default. |
To elaborate the above – if anyone is interested in doing this, all you have to do is update the existing implementation here and the tests. The key for updating the existing implementation is that we should use version checker to make sure we only do it if users have installed a version of Ember Data which supports the exports. @runspired @rwjblue I believe you looked at making the Babel polyfill for the modules work back a ways – did that happen, and if so, how far back? |
If people are wondering what to install manually, I think this is the list:
|
@Bouke Thanks for that list. Is there an official list of other packages to install manually after installing I'm getting errors import from modules that I didn't get before moving to TypeScript. One example is from |
Edit: I did not see the linked pull request. I am reviving this issue, should we add these new types to the blueprint? ember-cli-typescript/ts/blueprints/ember-cli-typescript/index.js Lines 146 to 169 in 7098f98
|
Fixed in #1411 |
This is a reminder issue, for https://discordapp.com/channels/480462759797063690/484421406659182603/683369672594292750
at the moment,
@ember-data/
types are not installedThe text was updated successfully, but these errors were encountered: