Merge pull request #649 from typed-ember/drop-node-6

Drop support for node 6 (EOL)

Author: chriskrycho

.eslintrc.js

@@ -70,7 +70,6 @@ module.exports = {
       },
       rules: {
         'node/no-unpublished-require': 'off',
-        'node/no-unsupported-features/es-syntax': 'off',
       },
     },
 

.vscode/settings.json

@@ -15,5 +15,6 @@
     "ember-beta": true,
     "ember-canary": true,
     "ember-default": true
-  }
+  },
+  "typescript.tsdk": "node_modules/typescript/lib"
 }

package.json

@@ -59,7 +59,6 @@
     "@typed-ember/renovate-config": "1.2.1",
     "@types/chai": "4.1.7",
     "@types/chai-as-promised": "7.1.0",
-    "@types/co": "4.6.1",
     "@types/console-ui": "2.2.0",
     "@types/core-object": "3.0.1",
     "@types/debug": "4.1.4",
@@ -134,7 +133,7 @@
     "hawk": "7"
   },
   "engines": {
-    "node": "6.* || 8.* || >= 10.*"
+    "node": "8.* || >= 10.*"
   },
   "ember-addon": {
     "configPath": "tests/dummy/config",

ts/tests/acceptance/build-test.ts

@@ -1,4 +1,3 @@
-import co from 'co';
 import SkeletonApp from '../helpers/skeleton-app';
 import chai from 'ember-cli-blueprint-test-helpers/chai';
 import * as esprima from 'esprima';
@@ -25,90 +24,78 @@ describe('Acceptance: build', function() {
     app.teardown();
   });
 
-  it(
-    'builds and rebuilds files',
-    co.wrap(function*() {
-      app.writeFile(
-        'app/app.ts',
-        `
+  it('builds and rebuilds files', async () => {
+    app.writeFile(
+      'app/app.ts',
+      `
       export function add(a: number, b: number) {
         return a + b;
       }
     `
-      );
+    );
 
-      let server = app.serve();
+    let server = app.serve();
 
-      yield server.waitForBuild();
+    await server.waitForBuild();
 
-      expectModuleBody(
-        app,
-        'skeleton-app/app',
-        `
+    expectModuleBody(
+      app,
+      'skeleton-app/app',
+      `
       _exports.add = add;
       function add(a, b) {
         return a + b;
       }
     `
-      );
+    );
 
-      app.writeFile(
-        'app/app.ts',
-        `
+    app.writeFile(
+      'app/app.ts',
+      `
       export const foo: string = 'hello';
     `
-      );
+    );
 
-      yield server.waitForBuild();
+    await server.waitForBuild();
 
-      expectModuleBody(
-        app,
-        'skeleton-app/app',
-        `
+    expectModuleBody(
+      app,
+      'skeleton-app/app',
+      `
       _exports.foo = void 0;
       var foo = 'hello';
       _exports.foo = foo;
     `
-      );
-    })
-  );
+    );
+  });
 
-  it(
-    'fails the build when noEmitOnError is set and an error is emitted',
-    co.wrap(function*() {
-      app.writeFile('app/app.ts', `import { foo } from 'nonexistent';`);
+  it('fails the build when noEmitOnError is set and an error is emitted', async () => {
+    app.writeFile('app/app.ts', `import { foo } from 'nonexistent';`);
 
-      yield expect(app.build()).to.be.rejectedWith(`Cannot find module 'nonexistent'`);
-    })
-  );
+    await expect(app.build()).to.be.rejectedWith(`Cannot find module 'nonexistent'`);
+  });
 
-  it(
-    'serves a type error page when the build has failed',
-    co.wrap(function*() {
-      app.writeFile('app/index.html', 'plain index');
-      app.writeFile('app/app.ts', `import { foo } from 'nonexistent';`);
+  it('serves a type error page when the build has failed', async () => {
+    app.writeFile('app/index.html', 'plain index');
+    app.writeFile('app/app.ts', `import { foo } from 'nonexistent';`);
 
-      let server = app.serve();
-      let output = yield server.waitForOutput('Typechecking failed');
-      let response = yield server.request('/');
+    let server = app.serve();
+    let output = await server.waitForOutput('Typechecking failed');
+    let response = await server.request('/');
 
-      expect(output).to.include(`Cannot find module 'nonexistent'`);
-      expect(response.body).to.include(`Cannot find module 'nonexistent'`);
-    })
-  );
+    expect(output).to.include(`Cannot find module 'nonexistent'`);
+    expect(response.body).to.include(`Cannot find module 'nonexistent'`);
+  });
 
-  it(
-    "doesn't block builds for file changes that don't result in a typecheck",
-    co.wrap(function*() {
-      let server = app.serve();
+  it("doesn't block builds for file changes that don't result in a typecheck", async () => {
+    let server = app.serve();
 
-      yield server.waitForBuild();
+    await server.waitForBuild();
 
-      app.writeFile('app/some-template.hbs', '');
+    app.writeFile('app/some-template.hbs', '');
 
-      yield server.waitForBuild();
-    })
-  );
+    await server.waitForBuild();
+  });
 });
 
 function isExpressionStatement(stmt: Statement | ModuleDeclaration): stmt is ExpressionStatement {