Skip to content

feat: enhance byText missing error #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MatanBobi
Copy link
Member

@MatanBobi MatanBobi commented Mar 25, 2022

Resolves #450.

Basically all I did was run the same normalize function that runs later on as part of the errors flow too.
This is a naive solution, I'm more than happy to see if I missed something there :)

@MatanBobi MatanBobi requested a review from eps1lon March 25, 2022 16:43
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 25, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b383620:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #1117 (b383620) into main (90d420d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1117   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          961       970    +9     
  Branches       312       316    +4     
=========================================
+ Hits           961       970    +9     
Flag Coverage Δ
node-12 100.00% <100.00%> (ø)
node-14 100.00% <100.00%> (ø)
node-16 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/queries/text.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90d420d...b383620. Read the comment docs.

@MatanBobi MatanBobi requested a review from timdeschryver March 25, 2022 16:46
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not a chore though. it's changing behavior the user can see. feature seems appropriate?

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for merging this as a feat

@MatanBobi MatanBobi changed the title chore: enhance byText missing error feat: enhance byText missing error Mar 26, 2022
@MatanBobi
Copy link
Member Author

@eps1lon @timdeschryver
Definitely, good point. It was my bad :)
Thanks!

@MatanBobi MatanBobi merged commit 77125fd into testing-library:main Mar 26, 2022
@MatanBobi
Copy link
Member Author

MatanBobi commented Mar 26, 2022

@all-contributors please add @eps1lon for review :)

@allcontributors
Copy link
Contributor

@MatanBobi

I've put up a pull request to add @eps1lon! 🎉

@MatanBobi
Copy link
Member Author

@all-contributors please add @timdeschryver for review :)

@allcontributors
Copy link
Contributor

@MatanBobi

I've put up a pull request to add @timdeschryver! 🎉

@github-actions
Copy link

🎉 This PR is included in version 8.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use normalized string in getByText error if text not found
3 participants