-
Notifications
You must be signed in to change notification settings - Fork 471
feat: enhance byText missing error #1117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance byText missing error #1117
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b383620:
|
Codecov Report
@@ Coverage Diff @@
## main #1117 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 961 970 +9
Branches 312 316 +4
=========================================
+ Hits 961 970 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's not a chore though. it's changing behavior the user can see. feature seems appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for merging this as a feat
@eps1lon @timdeschryver |
@all-contributors please add @eps1lon for review :) |
I've put up a pull request to add @eps1lon! 🎉 |
@all-contributors please add @timdeschryver for review :) |
I've put up a pull request to add @timdeschryver! 🎉 |
🎉 This PR is included in version 8.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves #450.
Basically all I did was run the same normalize function that runs later on as part of the errors flow too.
This is a naive solution, I'm more than happy to see if I missed something there :)