Skip to content

Commit f75ae54

Browse files
authored
refactor: unit tests (open-telemetry#198)
1 parent a27536e commit f75ae54

File tree

8 files changed

+49
-45
lines changed

8 files changed

+49
-45
lines changed

.nycrc

+5-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,11 @@
55
"exclude": [
66
"**/*.d.ts",
77
"build/**/**/*.js",
8-
"src/index.ts"
8+
"src/index.ts",
9+
"karma.conf.js",
10+
"src/platform/browser/*.ts",
11+
"test/index-webpack.ts",
12+
"webpack/*.js"
913
],
1014
"all": true
1115
}

packages/opentelemetry-core/test/context/BinaryTraceContext.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ describe('BinaryTraceContext', () => {
114114
},
115115
];
116116

117-
describe('toBytes', () => {
117+
describe('.toBytes()', () => {
118118
testCases.forEach(
119119
testCase =>
120120
testCase.structured &&
@@ -127,7 +127,7 @@ describe('BinaryTraceContext', () => {
127127
);
128128
});
129129

130-
describe('fromBytes', () => {
130+
describe('.fromBytes()', () => {
131131
testCases.forEach(testCase =>
132132
it(`should deserialize ${testCase.description}`, () => {
133133
assert.deepStrictEqual(

packages/opentelemetry-core/test/context/HttpTraceContext.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ describe('HttpTraceContext', () => {
3131
carrier = {};
3232
});
3333

34-
describe('inject', () => {
34+
describe('.inject()', () => {
3535
it('should set traceparent header', () => {
3636
const spanContext: SpanContext = {
3737
traceId: 'd4cda95b652f4a1592b449d5929fda1b',
@@ -64,7 +64,7 @@ describe('HttpTraceContext', () => {
6464
});
6565
});
6666

67-
describe('extract', () => {
67+
describe('.extract()', () => {
6868
it('should extract context of a sampled span from carrier', () => {
6969
carrier[TRACE_PARENT_HEADER] =
7070
'00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01';

packages/opentelemetry-core/test/trace/TracerDelegate.test.ts

+33-33
Original file line numberDiff line numberDiff line change
@@ -65,44 +65,44 @@ describe('TracerDelegate', () => {
6565
tracerDelegate.startSpan('foo');
6666
assert.deepStrictEqual(dummyTracer.spyCounter, 1);
6767
});
68+
});
6869

69-
describe('.start/stop()', () => {
70-
it('should use the fallback tracer when stop is called', () => {
71-
const dummyTracerUser = new DummyTracer();
72-
const dummyTracerFallback = new DummyTracer();
73-
const tracerDelegate = new TracerDelegate(
74-
dummyTracerUser,
75-
dummyTracerFallback
76-
);
70+
describe('.start/.stop()', () => {
71+
it('should use the fallback tracer when stop is called', () => {
72+
const dummyTracerUser = new DummyTracer();
73+
const dummyTracerFallback = new DummyTracer();
74+
const tracerDelegate = new TracerDelegate(
75+
dummyTracerUser,
76+
dummyTracerFallback
77+
);
7778

78-
tracerDelegate.stop();
79-
tracerDelegate.startSpan('fallback');
80-
assert.deepStrictEqual(dummyTracerUser.spyCounter, 0);
81-
assert.deepStrictEqual(dummyTracerFallback.spyCounter, 1);
82-
});
79+
tracerDelegate.stop();
80+
tracerDelegate.startSpan('fallback');
81+
assert.deepStrictEqual(dummyTracerUser.spyCounter, 0);
82+
assert.deepStrictEqual(dummyTracerFallback.spyCounter, 1);
83+
});
8384

84-
it('should use the user tracer when start is called', () => {
85-
const dummyTracerUser = new DummyTracer();
86-
const dummyTracerFallback = new DummyTracer();
87-
const tracerDelegate = new TracerDelegate(
88-
dummyTracerUser,
89-
dummyTracerFallback
90-
);
85+
it('should use the user tracer when start is called', () => {
86+
const dummyTracerUser = new DummyTracer();
87+
const dummyTracerFallback = new DummyTracer();
88+
const tracerDelegate = new TracerDelegate(
89+
dummyTracerUser,
90+
dummyTracerFallback
91+
);
9192

92-
tracerDelegate.stop();
93-
tracerDelegate.startSpan('fallback');
94-
assert.deepStrictEqual(dummyTracerUser.spyCounter, 0);
95-
assert.deepStrictEqual(dummyTracerFallback.spyCounter, 1);
93+
tracerDelegate.stop();
94+
tracerDelegate.startSpan('fallback');
95+
assert.deepStrictEqual(dummyTracerUser.spyCounter, 0);
96+
assert.deepStrictEqual(dummyTracerFallback.spyCounter, 1);
9697

97-
tracerDelegate.start();
98-
tracerDelegate.startSpan('user');
99-
assert.deepStrictEqual(dummyTracerUser.spyCounter, 1);
100-
assert.deepStrictEqual(
101-
dummyTracerFallback.spyCounter,
102-
1,
103-
'Only user tracer counter is incremented'
104-
);
105-
});
98+
tracerDelegate.start();
99+
tracerDelegate.startSpan('user');
100+
assert.deepStrictEqual(dummyTracerUser.spyCounter, 1);
101+
assert.deepStrictEqual(
102+
dummyTracerFallback.spyCounter,
103+
1,
104+
'Only user tracer counter is incremented'
105+
);
106106
});
107107
});
108108

packages/opentelemetry-core/test/trace/tracestate.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import * as assert from 'assert';
1818
import { TraceState } from '../../src/trace/TraceState';
1919

2020
describe('TraceState', () => {
21-
describe('serialize', () => {
21+
describe('.serialize()', () => {
2222
it('returns serialize string', () => {
2323
const state = new TraceState('a=1,b=2');
2424
assert.deepStrictEqual(state.serialize(), 'a=1,b=2');
@@ -52,7 +52,7 @@ describe('TraceState', () => {
5252
});
5353
});
5454

55-
describe('parse', () => {
55+
describe('.parse()', () => {
5656
it('must successfully parse valid state value', () => {
5757
const state = new TraceState(
5858
'vendorname2=opaqueValue2,vendorname1=opaqueValue1'

packages/opentelemetry-node-tracer/test/instrumentation/PluginLoader.test.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ describe('PluginLoader', () => {
3939
Object.keys(require.cache).forEach(key => delete require.cache[key]);
4040
});
4141

42-
describe('state()', () => {
42+
describe('.state()', () => {
4343
it('returns UNINITIALIZED when first called', () => {
4444
const pluginLoader = new PluginLoader(tracer, logger);
4545
assert.strictEqual(pluginLoader['_hookState'], HookState.UNINITIALIZED);
@@ -59,7 +59,7 @@ describe('PluginLoader', () => {
5959
});
6060
});
6161

62-
describe('load()', () => {
62+
describe('.load()', () => {
6363
it('sanity check', () => {
6464
// Ensure that module fixtures contain values that we expect.
6565
const simpleModule = require('simple-module');
@@ -107,7 +107,7 @@ describe('PluginLoader', () => {
107107
});
108108
});
109109

110-
describe('unload()', () => {
110+
describe('.unload()', () => {
111111
it('should unload the plugins and unpatch the target module when unloads', () => {
112112
const pluginLoader = new PluginLoader(tracer, logger);
113113
assert.strictEqual(pluginLoader['_plugins'].length, 0);

packages/opentelemetry-scope-async-hooks/test/asynchooks/AsyncHooksScopeManager.test.ts renamed to packages/opentelemetry-scope-async-hooks/test/AsyncHooksScopeManager.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
import * as assert from 'assert';
18-
import { AsyncHooksScopeManager } from '../../src';
18+
import { AsyncHooksScopeManager } from '../src';
1919

2020
describe('AsyncHooksScopeManager', () => {
2121
let scopeManager: AsyncHooksScopeManager;

packages/opentelemetry-scope-base/test/noop/NoopScopeManager.test.ts renamed to packages/opentelemetry-scope-base/test/NoopScopeManager.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
import * as assert from 'assert';
18-
import { NoopScopeManager } from '../../src';
18+
import { NoopScopeManager } from '../src';
1919

2020
describe('NoopScopeManager', () => {
2121
let scopeManager: NoopScopeManager;

0 commit comments

Comments
 (0)