Skip to content

Commit d3ce25c

Browse files
authored
chore: TODO cleanup (open-telemetry#439)
* chore: cleanup closed issues * chore: update basic tracer * chore: clear open-telemetry#59 * chore: clear todo in DEFAULT_CONFIG
1 parent 17690e6 commit d3ce25c

File tree

5 files changed

+0
-21
lines changed

5 files changed

+0
-21
lines changed

packages/opentelemetry-tracing/src/Span.ts

-6
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import { TraceParams } from './types';
2525
* This class represents a span.
2626
*/
2727
export class Span implements types.Span, ReadableSpan {
28-
private readonly _tracer: types.Tracer;
2928
// Below properties are included to implement ReadableSpan for export
3029
// purposes but are not intended to be written-to directly.
3130
readonly spanContext: types.SpanContext;
@@ -55,7 +54,6 @@ export class Span implements types.Span, ReadableSpan {
5554
parentSpanId?: string,
5655
startTime: types.TimeInput = hrTime()
5756
) {
58-
this._tracer = parentTracer;
5957
this.name = spanName;
6058
this.spanContext = spanContext;
6159
this.parentSpanId = parentSpanId;
@@ -67,10 +65,6 @@ export class Span implements types.Span, ReadableSpan {
6765
this._spanProcessor.onStart(this);
6866
}
6967

70-
tracer(): types.Tracer {
71-
return this._tracer;
72-
}
73-
7468
context(): types.SpanContext {
7569
return this.spanContext;
7670
}

packages/opentelemetry-tracing/src/config.ts

-2
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,4 @@ export const DEFAULT_CONFIG = {
4747
numberOfLinksPerSpan: DEFAULT_MAX_LINKS_PER_SPAN,
4848
numberOfEventsPerSpan: DEFAULT_MAX_EVENTS_PER_SPAN,
4949
},
50-
// @todo add support for plugins
51-
// plugins: {},
5250
};

packages/opentelemetry-tracing/test/Span.test.ts

-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ describe('Span', () => {
4545
it('should create a Span instance', () => {
4646
const span = new Span(tracer, name, spanContext, SpanKind.SERVER);
4747
assert.ok(span instanceof Span);
48-
assert.strictEqual(span.tracer(), tracer);
4948
span.end();
5049
});
5150

packages/opentelemetry-types/src/trace/span.ts

-10
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,6 @@ export interface Span {
3434
*/
3535
context(): SpanContext;
3636

37-
// /**
38-
// * # TODO
39-
// * Returns the Tracer object used to create this Span.
40-
// * https://github.com/open-telemetry/opentelemetry-specification/issues/21
41-
// */
42-
// tracer(): Tracer;
43-
4437
/**
4538
* Sets an attribute to the span.
4639
*
@@ -85,8 +78,6 @@ export interface Span {
8578
/**
8679
* Updates the Span name.
8780
*
88-
* TODO (revision): https://github.com/open-telemetry/opentelemetry-specification/issues/119
89-
*
9081
* @param name the Span name.
9182
*/
9283
updateName(name: string): this;
@@ -102,7 +93,6 @@ export interface Span {
10293
*
10394
* @param [endTime] the time to set as Span's end time. If not provided,
10495
* use the current time as the span's end time.
105-
* TODO (Add timestamp format): https://github.com/open-telemetry/opentelemetry-js/issues/19
10696
*/
10797
end(endTime?: TimeInput): void;
10898

packages/opentelemetry-types/src/trace/status.ts

-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ export interface Status {
2727

2828
/**
2929
* An enumeration of canonical status codes.
30-
*
31-
* TODO (revision): https://github.com/open-telemetry/opentelemetry-specification/issues/59
3230
*/
3331
export enum CanonicalCode {
3432
/**

0 commit comments

Comments
 (0)