Skip to content

Commit dd3f6e0

Browse files
committed
Changelog + unit tests for #2368
1 parent 89888ba commit dd3f6e0

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

package.xml

+1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
2727
<license uri="https://github.com/squizlabs/PHP_CodeSniffer/blob/master/licence.txt">BSD 3-Clause License</license>
2828
<notes>
2929
- Squiz.Arrays.ArrayDeclaration now has improved handling of syntax errors
30+
- Fixed bug #2368 : MySource.PHP.AjaxNullComparison throws error when first function has no doc comment
3031
- Fixed bug #2414 : Indention false positive in switch/case/if combination
3132
- Fixed bug #2423 : Squiz.Formatting.OperatorBracket.MissingBrackets error with static
3233
- Fixed bug #2450 : Indentation false positive when closure containing nested IF conditions used as function argument

src/Standards/MySource/Tests/PHP/AjaxNullComparisonUnitTest.inc

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
<?php
2+
3+
public static function foo() {
4+
}
5+
26
/**
37
* Adds a new issue.
48
*
@@ -176,4 +180,3 @@ public static function addIssue(
176180
}
177181

178182
}//end addIssue()
179-
?>

src/Standards/MySource/Tests/PHP/AjaxNullComparisonUnitTest.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@ public function getErrorList()
4141
public function getWarningList()
4242
{
4343
return [
44-
37 => 1,
45-
49 => 1,
46-
60 => 1,
47-
73 => 1,
48-
88 => 1,
49-
118 => 1,
44+
41 => 1,
45+
53 => 1,
46+
64 => 1,
47+
77 => 1,
48+
92 => 1,
49+
122 => 1,
5050
];
5151

5252
}//end getWarningList()

0 commit comments

Comments
 (0)