Skip to content

Error in javadoc for oauth2ResourceServer #7670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ah1508 opened this issue Nov 24, 2019 · 2 comments
Closed

Error in javadoc for oauth2ResourceServer #7670

ah1508 opened this issue Nov 24, 2019 · 2 comments
Assignees
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Milestone

Comments

@ah1508
Copy link

ah1508 commented Nov 24, 2019

Documentation for HttpSecurity oauth2ResourceServer(Customizer<OAuth2ResourceServerConfigurer<HttpSecurity>> oauth2ResourceServerCustomizer) method is wrong :

protected void configure(HttpSecurity http) throws Exception {
	http
		.authorizeRequests(authorizeRequests ->
			authorizeRequests
				.anyRequest().authenticated()
		)
		.oauth2ResourceServer(oauth2ResourceServer ->
			oauth2ResourceServer
				.jwt(jwt ->
					jwt
						.jwtAuthenticationConverter(jwtDecoder())
				)
		);
}

@Bean
public JwtDecoder jwtDecoder() {
	return JwtDecoders.fromOidcIssuerLocation(issuerUri);
}

jwtAuthenticationConverter methd expects a converter, not a decoder.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 24, 2019
@eleftherias
Copy link
Contributor

Thanks for the report @ah1508 ! Would you be interested in submitting a PR to fix the Javadoc?

@eleftherias eleftherias added in: docs An issue in Documentation or samples type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 27, 2019
@eleftherias eleftherias self-assigned this Nov 27, 2019
@Andrej37
Copy link

Thanks for the report @ah1508 ! Would you be interested in submitting a PR to fix the Javadoc?

Привет

@eleftherias eleftherias changed the title error in javadoc for oauth2ResourceServer Error in javadoc for oauth2ResourceServer Dec 27, 2019
@eleftherias eleftherias added this to the 5.3.0.M1 milestone Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Development

No branches or pull requests

4 participants