Skip to content

Polish Resource Server DSL Error Messaging #6876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue May 14, 2019 · 0 comments
Closed

Polish Resource Server DSL Error Messaging #6876

jzheaux opened this issue May 14, 2019 · 0 comments
Assignees
@jzheaux
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.2.0.RC1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented May 14, 2019

It is possible to configure Resource Server like so:

http
    .oauth2ResourceServer()
        .authenticationManagerResolver()
        .jwt()
            .jwtDecoder();

However, this configuration doesn't make sense because AuthenticationManagerResolver supercedes any individually configured authentication mechanism.

We should error in this case since it's an invalid configuration. Specifically, if an AuthenticationManagerResolver is specified, then we should error if either jwt or opaqueToken is specified.
@jzheaux jzheaux self-assigned this May 14, 2019
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement labels May 14, 2019
@jzheaux jzheaux added this to the 5.2.0.M3 milestone May 14, 2019
@jzheaux jzheaux mentioned this issue Jun 10, 2019
Merged
@eleftherias eleftherias modified the milestones: 5.2.0.M3, 5.2.0.RC1 Jun 14, 2019
@jzheaux jzheaux modified the milestones: 5.2.0.M4, 5.2.0.RC1 Aug 5, 2019
@jzheaux jzheaux closed this as completed in de672e3 Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.RC1
Development

No branches or pull requests
2 participants
@jzheaux @eleftherias