Skip to content

OAuth2AuthenticationToken.ClientRegistration -> AuthorizedClient #4520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgrandja opened this issue Sep 12, 2017 · 1 comment
Closed

OAuth2AuthenticationToken.ClientRegistration -> AuthorizedClient #4520

jgrandja opened this issue Sep 12, 2017 · 1 comment
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Milestone
5.0.0.M5

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Sep 12, 2017 •
edited
Loading

The OAuth2AuthenticationToken currently has a ClientRegistration attribute associated with it.
However, it makes much more sense to replace this and introduce a new construct that represents an instance of an Authorized Client.

An OAuth2AuthenticationToken represents a combination of an authentication of an end-user at the external identity provider as well as an authorized client by the end-user during the consent/authorization step of the Authorization Code grant flow. It makes a lot more sense to have an AuthorizedClient construct given that it's really an instance of ClientRegistration. For example, the same client (from a ClientRegistration) may be authorized more than once depending on the authorization grants it's configured with and the flows it's goes through.
@jgrandja jgrandja self-assigned this Sep 12, 2017
@jgrandja jgrandja added the in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) label Sep 12, 2017
@jgrandja jgrandja added this to the 5.0.0.M4 milestone Sep 12, 2017
@jgrandja jgrandja changed the title Replace OAuth2AuthenticationToken.ClientRegistration -> AuthorizedClient OAuth2AuthenticationToken.ClientRegistration -> AuthorizedClient Sep 12, 2017
This was referenced Sep 12, 2017
Closed
Closed
@rwinch rwinch modified the milestones: 5.0.0.M4, 5.0.0.M5 Sep 13, 2017
@jgrandja
Copy link
Contributor Author

Resolved via #4553 as OAuth2ClientAuthenticationToken represents an Authorized Client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Projects
None yet
Milestone
5.0.0.M5
Development

No branches or pull requests
2 participants
@rwinch @jgrandja